Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3545)

Unified Diff: chrome/browser/external_tab_container_win.h

Issue 8253002: Move PageTransition into content namespace. While I'm touching all these files, I've also updated... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/window_open_apitest.cc ('k') | chrome/browser/external_tab_container_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/external_tab_container_win.h
===================================================================
--- chrome/browser/external_tab_container_win.h (revision 105162)
+++ chrome/browser/external_tab_container_win.h (working copy)
@@ -119,12 +119,13 @@
// Deprecated. Please used two-arguments variant.
// TODO(adriansc): Remove method once refactoring changed all call sites.
+ virtual TabContents* OpenURLFromTab(
+ TabContents* source,
+ const GURL& url,
+ const GURL& referrer,
+ WindowOpenDisposition disposition,
+ content::PageTransition transition) OVERRIDE;
virtual TabContents* OpenURLFromTab(TabContents* source,
- const GURL& url,
- const GURL& referrer,
- WindowOpenDisposition disposition,
- PageTransition::Type transition) OVERRIDE;
- virtual TabContents* OpenURLFromTab(TabContents* source,
const OpenURLParams& params) OVERRIDE;
virtual void NavigationStateChanged(const TabContents* source,
unsigned changed_flags);
@@ -373,10 +374,11 @@
// Deprecated. Please use the two-argument variant.
// TODO(adriansc): Remove method once refactoring changed all call sites.
- virtual TabContents* OpenURLFromTab(TabContents* source, const GURL& url,
- const GURL& referrer,
- WindowOpenDisposition disposition,
- PageTransition::Type transition) OVERRIDE;
+ virtual TabContents* OpenURLFromTab(
+ TabContents* source, const GURL& url,
+ const GURL& referrer,
+ WindowOpenDisposition disposition,
+ content::PageTransition transition) OVERRIDE;
virtual TabContents* OpenURLFromTab(TabContents* source,
const OpenURLParams& params) OVERRIDE;
« no previous file with comments | « chrome/browser/extensions/window_open_apitest.cc ('k') | chrome/browser/external_tab_container_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698