Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: content/browser/tab_contents/tab_contents_observer.cc

Issue 8253002: Move PageTransition into content namespace. While I'm touching all these files, I've also updated... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/tab_contents/tab_contents_observer.h" 5 #include "content/browser/tab_contents/tab_contents_observer.h"
6 6
7 #include "content/browser/renderer_host/render_view_host.h" 7 #include "content/browser/renderer_host/render_view_host.h"
8 #include "content/browser/tab_contents/navigation_details.h" 8 #include "content/browser/tab_contents/navigation_details.h"
9 #include "content/browser/tab_contents/tab_contents.h" 9 #include "content/browser/tab_contents/tab_contents.h"
10 10
(...skipping 25 matching lines...) Expand all
36 36
37 void TabContentsObserver::ProvisionalChangeToMainFrameUrl( 37 void TabContentsObserver::ProvisionalChangeToMainFrameUrl(
38 const GURL& url, 38 const GURL& url,
39 const GURL& opener_url) { 39 const GURL& opener_url) {
40 } 40 }
41 41
42 void TabContentsObserver::DidCommitProvisionalLoadForFrame( 42 void TabContentsObserver::DidCommitProvisionalLoadForFrame(
43 int64 frame_id, 43 int64 frame_id,
44 bool is_main_frame, 44 bool is_main_frame,
45 const GURL& url, 45 const GURL& url,
46 PageTransition::Type transition_type) { 46 content::PageTransition transition_type) {
47 } 47 }
48 48
49 void TabContentsObserver::DidFailProvisionalLoad( 49 void TabContentsObserver::DidFailProvisionalLoad(
50 int64 frame_id, 50 int64 frame_id,
51 bool is_main_frame, 51 bool is_main_frame,
52 const GURL& validated_url, 52 const GURL& validated_url,
53 int error_code, 53 int error_code,
54 const string16& error_description) { 54 const string16& error_description) {
55 } 55 }
56 56
(...skipping 20 matching lines...) Expand all
77 77
78 void TabContentsObserver::RenderViewGone() { 78 void TabContentsObserver::RenderViewGone() {
79 } 79 }
80 80
81 void TabContentsObserver::StopNavigation() { 81 void TabContentsObserver::StopNavigation() {
82 } 82 }
83 83
84 void TabContentsObserver::DidOpenURL(const GURL& url, 84 void TabContentsObserver::DidOpenURL(const GURL& url,
85 const GURL& referrer, 85 const GURL& referrer,
86 WindowOpenDisposition disposition, 86 WindowOpenDisposition disposition,
87 PageTransition::Type transition) { 87 content::PageTransition transition) {
88 } 88 }
89 89
90 void TabContentsObserver::DidOpenRequestedURL(TabContents* new_contents, 90 void TabContentsObserver::DidOpenRequestedURL(
91 const GURL& url, 91 TabContents* new_contents,
92 const GURL& referrer, 92 const GURL& url,
93 WindowOpenDisposition disposition, 93 const GURL& referrer,
94 PageTransition::Type transition, 94 WindowOpenDisposition disposition,
95 int64 source_frame_id) { 95 content::PageTransition transition,
96 int64 source_frame_id) {
96 } 97 }
97 98
98 void TabContentsObserver::AppCacheAccessed(const GURL& manifest_url, 99 void TabContentsObserver::AppCacheAccessed(const GURL& manifest_url,
99 bool blocked_by_policy) { 100 bool blocked_by_policy) {
100 } 101 }
101 102
102 TabContentsObserver::TabContentsObserver(TabContents* tab_contents) 103 TabContentsObserver::TabContentsObserver(TabContents* tab_contents)
103 : tab_contents_(NULL), routing_id_(MSG_ROUTING_NONE) { 104 : tab_contents_(NULL), routing_id_(MSG_ROUTING_NONE) {
104 Observe(tab_contents); 105 Observe(tab_contents);
105 } 106 }
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 } 148 }
148 149
149 void TabContentsObserver::TabContentsDestroyed() { 150 void TabContentsObserver::TabContentsDestroyed() {
150 // Do cleanup so that 'this' can safely be deleted from 151 // Do cleanup so that 'this' can safely be deleted from
151 // TabContentsDestroyed. 152 // TabContentsDestroyed.
152 tab_contents_->RemoveObserver(this); 153 tab_contents_->RemoveObserver(this);
153 TabContents* tab = tab_contents_; 154 TabContents* tab = tab_contents_;
154 tab_contents_ = NULL; 155 tab_contents_ = NULL;
155 TabContentsDestroyed(tab); 156 TabContentsDestroyed(tab);
156 } 157 }
OLDNEW
« no previous file with comments | « content/browser/tab_contents/tab_contents_observer.h ('k') | content/browser/tab_contents/test_tab_contents.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698