Made Authenticator::CompleteLogin, AuthenticateToLogin and AuthenticateToUnlock return void.

Made Authenticator::CompleteLogin, AuthenticateToLogin and AuthenticateToUnlock return void.

They were anyhow hardcoded to return true and didn't play nicely with base::Bind.
The result of an authentication is being reported through the callbacks
OnLoginSuccess and OnLoginFailure.


BUG=chromium-os:14054
TEST=Everything should compile. browser_tests should be still passing.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102118

[pastarmovj, 2011-09-21 12:15:47]

This turned out while working on the bigger refactoring CL you reviewed
yesterday.
I thought I will just use the occasion to fix all old-school calls to
NewRunnableXXXX with a base::Bind calls but these don't like functions that have
non-void return values. And the Authenticator class has some of these but it
doesn't even use the return value ever so I just refactored them to returning
void.

[Denis Lagno, 2011-09-21 13:14:45]

LGTM

[commit-bot: I haz the power, 2011-09-21 17:00:43]

Change committed as 102118