Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1084)

Unified Diff: chrome/browser/chromeos/login/parallel_authenticator.h

Issue 7982025: Made Authenticator::CompleteLogin, AuthenticateToLogin and AuthenticateToUnlock return void. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: One more obsolete comment fixed. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/parallel_authenticator.h
diff --git a/chrome/browser/chromeos/login/parallel_authenticator.h b/chrome/browser/chromeos/login/parallel_authenticator.h
index e6400580cf862280e0b46b009140095e1c85fa57..98dc49bf0133da112cfd9563b0bf8e6630776983 100644
--- a/chrome/browser/chromeos/login/parallel_authenticator.h
+++ b/chrome/browser/chromeos/login/parallel_authenticator.h
@@ -84,7 +84,7 @@ class ParallelAuthenticator : public Authenticator,
virtual ~ParallelAuthenticator();
// Authenticator overrides.
- virtual bool CompleteLogin(Profile* profile,
+ virtual void CompleteLogin(Profile* profile,
const std::string& username,
const std::string& password) OVERRIDE;
@@ -113,9 +113,7 @@ class ParallelAuthenticator : public Authenticator,
// NOTE: We do not allow HOSTED accounts to log in. In the event that
// we are asked to authenticate valid HOSTED account creds, we will
// call OnLoginFailure() with HOSTED_NOT_ALLOWED.
- //
- // Returns true if the attempt gets sent successfully and false if not.
- virtual bool AuthenticateToLogin(Profile* profile,
+ virtual void AuthenticateToLogin(Profile* profile,
const std::string& username,
const std::string& password,
const std::string& login_token,
@@ -125,7 +123,7 @@ class ParallelAuthenticator : public Authenticator,
// authenticate to the cached credentials. This will never contact
// the server even if it's online. The auth result is sent to
// LoginStatusConsumer in a same way as AuthenticateToLogin does.
- virtual bool AuthenticateToUnlock(const std::string& username,
+ virtual void AuthenticateToUnlock(const std::string& username,
const std::string& password) OVERRIDE;
// Initiates incognito ("browse without signing in") login.
« no previous file with comments | « chrome/browser/chromeos/login/mock_authenticator.cc ('k') | chrome/browser/chromeos/login/parallel_authenticator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698