Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: chrome/browser/chromeos/login/google_authenticator.h

Issue 7982025: Made Authenticator::CompleteLogin, AuthenticateToLogin and AuthenticateToUnlock return void. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: One more obsolete comment fixed. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/google_authenticator.h
diff --git a/chrome/browser/chromeos/login/google_authenticator.h b/chrome/browser/chromeos/login/google_authenticator.h
index 6d38e113ba0deb39b9f825b4043951910f6bf459..d969d829e3afe05c8aaf0b71be2eacd4da739c52 100644
--- a/chrome/browser/chromeos/login/google_authenticator.h
+++ b/chrome/browser/chromeos/login/google_authenticator.h
@@ -46,8 +46,7 @@ class GoogleAuthenticator : public Authenticator, public GaiaAuthConsumer {
// a callback to consumer_->OnLoginSuccess() with the |username| and a vector
// of authentication cookies or a callback to consumer_->OnLoginFailure() with
// an error message.
- // Returns true if the attempt gets sent successfully and false if not.
- virtual bool CompleteLogin(Profile* profile,
+ virtual void CompleteLogin(Profile* profile,
const std::string& username,
const std::string& password) OVERRIDE;
@@ -62,9 +61,7 @@ class GoogleAuthenticator : public Authenticator, public GaiaAuthConsumer {
// NOTE: We do not allow HOSTED accounts to log in. In the event that
// we are asked to authenticate valid HOSTED account creds, we will
// call OnLoginFailure() with HOSTED_NOT_ALLOWED.
- //
- // Returns true if the attempt gets sent successfully and false if not.
- virtual bool AuthenticateToLogin(Profile* profile,
+ virtual void AuthenticateToLogin(Profile* profile,
const std::string& username,
const std::string& password,
const std::string& login_token,
@@ -74,7 +71,7 @@ class GoogleAuthenticator : public Authenticator, public GaiaAuthConsumer {
// authenticate to the cached credentials. This will never contact
// the server even if it's online. The auth result is sent to
// LoginStatusConsumer in a same way as AuthenticateToLogin does.
- virtual bool AuthenticateToUnlock(const std::string& username,
+ virtual void AuthenticateToUnlock(const std::string& username,
const std::string& password) OVERRIDE;
// Initiates incognito ("browse without signing in") login.
« no previous file with comments | « chrome/browser/chromeos/login/authenticator.h ('k') | chrome/browser/chromeos/login/google_authenticator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698