Made Authenticator::CompleteLogin, AuthenticateToLogin and AuthenticateToUnlock return void.

chrome/browser/chromeos/login/parallel_authenticator.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_PARALLEL_AUTHENTICATOR_H_
 #define CHROME_BROWSER_CHROMEOS_LOGIN_PARALLEL_AUTHENTICATOR_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 66 matching lines @@
     UNLOCK,          // Screen unlock succeeded.
     LOCAL_LOGIN,     // Login with localaccount succeded.
     ONLINE_FAILED,   // Online login disallowed, but offline succeeded.
     LOGIN_FAILED     // Login denied.
   };
 
   explicit ParallelAuthenticator(LoginStatusConsumer* consumer);
   virtual ~ParallelAuthenticator();
 
   // Authenticator overrides.
-  virtual bool CompleteLogin(Profile* profile,
+  virtual void CompleteLogin(Profile* profile,
                              const std::string& username,
                              const std::string& password) OVERRIDE;
 
   // Given a |username| and |password|, this method attempts to authenticate to
   // the Google accounts servers and your Chrome OS device simultaneously.
   // As soon as we have successfully mounted the encrypted home directory for
   // |username|, we will call consumer_->OnLoginSuccess() with |username| and a
   // vector of authentication cookies.  If we're still waiting for an online
   // result at that time, we'll also pass back a flag indicating that more
   // callbacks are on the way; if not, we pass back false.  When the pending
   // request completes, either consumer_->OnLoginSuccess() with an indication
   // that no more requests are outstanding will be called, or
   // consumer_->OnLoginFailure() if appropriate.
   //
   // Upon failure to login (online fails, then offline fails;
   // offline fails, then online fails) consumer_->OnLoginFailure() is called
   // with an error message.
   //
   // In the event that we see an online success and then an offline failure,
   // consumer_->OnPasswordChangeDetected() is called.
   //
   // Uses |profile| when doing URL fetches.
   // Optionally could pass CAPTCHA challenge token - |login_token| and
   // |login_captcha| string that user has entered.
   //
   // NOTE: We do not allow HOSTED accounts to log in.  In the event that
   // we are asked to authenticate valid HOSTED account creds, we will
   // call OnLoginFailure() with HOSTED_NOT_ALLOWED.
-  //
-  // Returns true if the attempt gets sent successfully and false if not.
-  virtual bool AuthenticateToLogin(Profile* profile,
+  virtual void AuthenticateToLogin(Profile* profile,
                                    const std::string& username,
                                    const std::string& password,
                                    const std::string& login_token,
                                    const std::string& login_captcha) OVERRIDE;
 
   // Given a |username| and |password|, this method attempts to
   // authenticate to the cached credentials. This will never contact
   // the server even if it's online. The auth result is sent to
   // LoginStatusConsumer in a same way as AuthenticateToLogin does.
-  virtual bool AuthenticateToUnlock(const std::string& username,
+  virtual void AuthenticateToUnlock(const std::string& username,
                                     const std::string& password) OVERRIDE;
 
   // Initiates incognito ("browse without signing in") login.
   // Mounts tmpfs and notifies consumer on the success/failure.
   virtual void LoginOffTheRecord() OVERRIDE;
 
   // These methods must be called on the UI thread, as they make DBus calls
   // and also call back to the login UI.
   virtual void OnLoginSuccess(
       const GaiaAuthConsumer::ClientLoginResult& credentials,
@@ skipping 168 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(ParallelAuthenticatorTest, ReadLocalaccount);
   FRIEND_TEST_ALL_PREFIXES(ParallelAuthenticatorTest,
                            ReadLocalaccountTrailingWS);
   FRIEND_TEST_ALL_PREFIXES(ParallelAuthenticatorTest, ReadNoLocalaccount);
   DISALLOW_COPY_AND_ASSIGN(ParallelAuthenticator);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_LOGIN_PARALLEL_AUTHENTICATOR_H_