Made Authenticator::CompleteLogin, AuthenticateToLogin and AuthenticateToUnlock return void.

chrome/browser/chromeos/login/parallel_authenticator.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/parallel_authenticator.h"
 
 #include <string>
 #include <vector>
 
 #include "base/command_line.h"
@@ skipping 87 matching lines @@
           !CommandLine::ForCurrentProcess()->HasSwitch(
                   switches::kSkipOAuthLogin)) {
   CHECK(chromeos::CrosLibrary::Get()->EnsureLoaded());
   // If not already owned, this is a no-op.  If it is, this loads the owner's
   // public key off of disk.
   OwnershipService::GetSharedInstance()->StartLoadOwnerKeyAttempt();
 }
 
 ParallelAuthenticator::~ParallelAuthenticator() {}
 
-bool ParallelAuthenticator::AuthenticateToLogin(
+void ParallelAuthenticator::AuthenticateToLogin(
     Profile* profile,
     const std::string& username,
     const std::string& password,
     const std::string& login_token,
     const std::string& login_captcha) {
   std::string canonicalized = Authenticator::Canonicalize(username);
   authentication_profile_ = profile;
   current_state_.reset(
       new AuthAttemptState(canonicalized,
                            password,
@@ skipping 17 matching lines @@
                                         current_state_.get(),
                                         this);
     current_online_->Initiate(profile);
   }
 
   BrowserThread::PostTask(
       BrowserThread::FILE, FROM_HERE,
       NewRunnableMethod(this,
                         &ParallelAuthenticator::LoadLocalaccount,
                         std::string(kLocalaccountFile)));
-  return true;
 }
 
-bool ParallelAuthenticator::CompleteLogin(Profile* profile,
+void ParallelAuthenticator::CompleteLogin(Profile* profile,
                                           const std::string& username,
                                           const std::string& password) {
   std::string canonicalized = Authenticator::Canonicalize(username);
   authentication_profile_ = profile;
   current_state_.reset(
       new AuthAttemptState(canonicalized,
                            password,
                            HashPassword(password),
                            !UserManager::Get()->IsKnownUser(canonicalized)));
   mounter_ = CryptohomeOp::CreateMountAttempt(current_state_.get(),
@@ skipping 21 matching lines @@
         BrowserThread::IO, FROM_HERE,
         NewRunnableMethod(this,
             &ParallelAuthenticator::ResolveLoginCompletionStatus));
   }
 
   BrowserThread::PostTask(
       BrowserThread::FILE, FROM_HERE,
       NewRunnableMethod(this,
                         &ParallelAuthenticator::LoadLocalaccount,
                         std::string(kLocalaccountFile)));
-  return true;
 }
 
-bool ParallelAuthenticator::AuthenticateToUnlock(const std::string& username,
+void ParallelAuthenticator::AuthenticateToUnlock(const std::string& username,
                                                  const std::string& password) {
   current_state_.reset(
       new AuthAttemptState(Authenticator::Canonicalize(username),
                            HashPassword(password)));
   BrowserThread::PostTask(
       BrowserThread::FILE, FROM_HERE,
       NewRunnableMethod(this,
                         &ParallelAuthenticator::LoadLocalaccount,
                         std::string(kLocalaccountFile)));
   key_checker_ = CryptohomeOp::CreateCheckKeyAttempt(current_state_.get(),
                                                      this);
   // Sadly, this MUST be on the UI thread due to sending DBus traffic :-/
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
       NewRunnableMethod(key_checker_.get(), &CryptohomeOp::Initiate));
-  return true;
 }
 
 void ParallelAuthenticator::LoginOffTheRecord() {
   current_state_.reset(new AuthAttemptState("", "", "", "", "", false));
   guest_mounter_ =
       CryptohomeOp::CreateMountGuestAttempt(current_state_.get(), this);
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   guest_mounter_->Initiate();
 }
 
@@ skipping 585 matching lines @@
 }
 
 void ParallelAuthenticator::ResolveLoginCompletionStatus() {
   // Shortcut online state resolution process.
   current_state_->RecordOnlineLoginStatus(GaiaAuthConsumer::ClientLoginResult(),
                                           LoginFailure::None());
   Resolve();
 }
 
 }  // namespace chromeos