Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4853)

Unified Diff: chrome/browser/chromeos/login/google_authenticator.cc

Issue 7982025: Made Authenticator::CompleteLogin, AuthenticateToLogin and AuthenticateToUnlock return void. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: One more obsolete comment fixed. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/google_authenticator.cc
diff --git a/chrome/browser/chromeos/login/google_authenticator.cc b/chrome/browser/chromeos/login/google_authenticator.cc
index a0877b457994713c9dfe03210e0c8bf0d666e46d..9a8f718303e794933446241700a35ff8cfbaf53e 100644
--- a/chrome/browser/chromeos/login/google_authenticator.cc
+++ b/chrome/browser/chromeos/login/google_authenticator.cc
@@ -117,7 +117,7 @@ void GoogleAuthenticator::ClearClientLoginAttempt() {
login_token_.clear();
login_captcha_.clear();
}
-bool GoogleAuthenticator::CompleteLogin(Profile* profile,
+void GoogleAuthenticator::CompleteLogin(Profile* profile,
const std::string& username,
const std::string& password) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
@@ -130,10 +130,9 @@ bool GoogleAuthenticator::CompleteLogin(Profile* profile,
NewRunnableMethod(this,
&GoogleAuthenticator::OnLoginSuccess,
GaiaAuthConsumer::ClientLoginResult(), false));
- return true;
}
-bool GoogleAuthenticator::AuthenticateToLogin(
+void GoogleAuthenticator::AuthenticateToLogin(
Profile* profile,
const std::string& username,
const std::string& password,
@@ -154,10 +153,9 @@ bool GoogleAuthenticator::AuthenticateToLogin(
// Will be used for retries.
PrepareClientLoginAttempt(password, login_token, login_captcha);
TryClientLogin();
- return true;
}
-bool GoogleAuthenticator::AuthenticateToUnlock(const std::string& username,
+void GoogleAuthenticator::AuthenticateToUnlock(const std::string& username,
const std::string& password) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
username_.assign(Canonicalize(username));
@@ -172,7 +170,6 @@ bool GoogleAuthenticator::AuthenticateToUnlock(const std::string& username,
BrowserThread::UI, FROM_HERE,
NewRunnableMethod(this, &GoogleAuthenticator::CheckOffline,
LoginFailure(LoginFailure::UNLOCK_FAILED)));
- return true;
}
void GoogleAuthenticator::LoginOffTheRecord() {
« no previous file with comments | « chrome/browser/chromeos/login/google_authenticator.h ('k') | chrome/browser/chromeos/login/mock_authenticator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698