Made Authenticator::CompleteLogin, AuthenticateToLogin and AuthenticateToUnlock return void.

chrome/browser/chromeos/login/google_authenticator.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/google_authenticator.h"
 
 #include <string>
 #include <vector>
 
 #include "base/file_path.h"
@@ skipping 99 matching lines @@
   login_token_.assign(token);
   login_captcha_.assign(captcha);
 }
 
 void GoogleAuthenticator::ClearClientLoginAttempt() {
   // Not clearing the password, because we may need to pass it to the
   // sync service if login is successful.
   login_token_.clear();
   login_captcha_.clear();
 }
-bool GoogleAuthenticator::CompleteLogin(Profile* profile,
+void GoogleAuthenticator::CompleteLogin(Profile* profile,
                                         const std::string& username,
                                         const std::string& password) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   authentication_profile_ = profile;
   username_.assign(Canonicalize(username));
   ascii_hash_.assign(HashPassword(password));
 
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
       NewRunnableMethod(this,
                         &GoogleAuthenticator::OnLoginSuccess,
                         GaiaAuthConsumer::ClientLoginResult(), false));
-  return true;
 }
 
-bool GoogleAuthenticator::AuthenticateToLogin(
+void GoogleAuthenticator::AuthenticateToLogin(
     Profile* profile,
     const std::string& username,
     const std::string& password,
     const std::string& login_token,
     const std::string& login_captcha) {
   unlock_ = false;
   authentication_profile_ = profile;
 
   // TODO(cmasone): Figure out how to parallelize fetch, username/password
   // processing without impacting testability.
   username_.assign(Canonicalize(username));
   ascii_hash_.assign(HashPassword(password));
 
   gaia_authenticator_.reset(
       new GaiaAuthFetcher(this,
                           GaiaConstants::kChromeOSSource,
                           profile->GetRequestContext()));
   // Will be used for retries.
   PrepareClientLoginAttempt(password, login_token, login_captcha);
   TryClientLogin();
-  return true;
 }
 
-bool GoogleAuthenticator::AuthenticateToUnlock(const std::string& username,
+void GoogleAuthenticator::AuthenticateToUnlock(const std::string& username,
                                                const std::string& password) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   username_.assign(Canonicalize(username));
   ascii_hash_.assign(HashPassword(password));
   unlock_ = true;
   BrowserThread::PostTask(
       BrowserThread::FILE, FROM_HERE,
       NewRunnableMethod(this,
                         &GoogleAuthenticator::LoadLocalaccount,
                         std::string(kLocalaccountFile)));
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
       NewRunnableMethod(this, &GoogleAuthenticator::CheckOffline,
                         LoginFailure(LoginFailure::UNLOCK_FAILED)));
-  return true;
 }
 
 void GoogleAuthenticator::LoginOffTheRecord() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   int mount_error = chromeos::kCryptohomeMountErrorNone;
   if (CrosLibrary::Get()->GetCryptohomeLibrary()->MountForBwsi(&mount_error)) {
     AuthenticationNotificationDetails details(true);
     NotificationService::current()->Notify(
         chrome::NOTIFICATION_LOGIN_AUTHENTICATION,
         NotificationService::AllSources(),
@@ skipping 322 matching lines @@
                                       const unsigned int len) {
   if (len < 2*binary_len)
     return false;
   memset(hex_string, 0, len);
   for (uint i = 0, j = 0; i < binary_len; i++, j+=2)
     snprintf(hex_string + j, len - j, "%02x", binary[i]);
   return true;
 }
 
 }  // namespace chromeos