Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 7977005: Put back the asserts in RememberedSetHelper, but correct this time. (Closed)

Created:
9 years, 3 months ago by Erik Corry
Modified:
9 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Put back the asserts in RememberedSetHelper, but correct this time. Fix some incorrect comments. Committed: http://code.google.com/p/v8/source/detail?r=9344

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -49 lines) Patch
M src/arm/code-stubs-arm.cc View 5 chunks +21 lines, -9 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +10 lines, -4 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +8 lines, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 5 chunks +21 lines, -9 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +10 lines, -4 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 3 chunks +4 lines, -3 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 4 chunks +20 lines, -8 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +10 lines, -4 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 3 chunks +5 lines, -4 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
9 years, 3 months ago (2011-09-20 13:01:58 UTC) #1
Vyacheslav Egorov (Chromium)
9 years, 3 months ago (2011-09-20 13:31:59 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698