Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Side by Side Diff: src/x64/macro-assembler-x64.h

Issue 7977005: Put back the asserts in RememberedSetHelper, but correct this time. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 158
159 159
160 enum RememberedSetFinalAction { 160 enum RememberedSetFinalAction {
161 kReturnAtEnd, 161 kReturnAtEnd,
162 kFallThroughAtEnd 162 kFallThroughAtEnd
163 }; 163 };
164 164
165 // Record in the remembered set the fact that we have a pointer to new space 165 // Record in the remembered set the fact that we have a pointer to new space
166 // at the address pointed to by the addr register. Only works if addr is not 166 // at the address pointed to by the addr register. Only works if addr is not
167 // in new space. 167 // in new space.
168 void RememberedSetHelper(Register addr, 168 void RememberedSetHelper(Register object, // Used for debug code.
169 Register addr,
169 Register scratch, 170 Register scratch,
170 SaveFPRegsMode save_fp, 171 SaveFPRegsMode save_fp,
171 RememberedSetFinalAction and_then); 172 RememberedSetFinalAction and_then);
172 173
173 void CheckPageFlag(Register object, 174 void CheckPageFlag(Register object,
174 Register scratch, 175 Register scratch,
175 int mask, 176 int mask,
176 Condition cc, 177 Condition cc,
177 Label* condition_met, 178 Label* condition_met,
178 Label::Distance condition_met_distance = Label::kFar); 179 Label::Distance condition_met_distance = Label::kFar);
179 180
180 // Check if object is in new space. Jumps if the object is not in new space. 181 // Check if object is in new space. Jumps if the object is not in new space.
181 // The register scratch can be object itself, but it will be clobbered. 182 // The register scratch can be object itself, but scratch will be clobbered.
182 void JumpIfNotInNewSpace(Register object, 183 void JumpIfNotInNewSpace(Register object,
183 Register scratch, 184 Register scratch,
184 Label* branch, 185 Label* branch,
185 Label::Distance distance = Label::kFar) { 186 Label::Distance distance = Label::kFar) {
186 InNewSpace(object, scratch, not_equal, branch, distance); 187 InNewSpace(object, scratch, not_equal, branch, distance);
187 } 188 }
188 189
189 // Check if object is in new space. Jumps if the object is in new space. 190 // Check if object is in new space. Jumps if the object is in new space.
190 // The register scratch can be object itself, but it will be clobbered. 191 // The register scratch can be object itself, but it will be clobbered.
191 void JumpIfInNewSpace(Register object, 192 void JumpIfInNewSpace(Register object,
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
260 // filters out smis so it does not update the write barrier if the 261 // filters out smis so it does not update the write barrier if the
261 // value is a smi. 262 // value is a smi.
262 void RecordWriteArray( 263 void RecordWriteArray(
263 Register array, 264 Register array,
264 Register value, 265 Register value,
265 Register index, 266 Register index,
266 SaveFPRegsMode save_fp, 267 SaveFPRegsMode save_fp,
267 RememberedSetAction remembered_set_action = EMIT_REMEMBERED_SET, 268 RememberedSetAction remembered_set_action = EMIT_REMEMBERED_SET,
268 SmiCheck smi_check = INLINE_SMI_CHECK); 269 SmiCheck smi_check = INLINE_SMI_CHECK);
269 270
270 // For page containing |object| mark region covering [address] 271 // For page containing |object| mark region covering |address|
271 // dirty. |object| is the object being stored into, |value| is the 272 // dirty. |object| is the object being stored into, |value| is the
272 // object being stored. All registers are clobbered by the 273 // object being stored. The address and value registers are clobbered by the
273 // operation. RecordWrite filters out smis so it does not update 274 // operation. RecordWrite filters out smis so it does not update
274 // the write barrier if the value is a smi. 275 // the write barrier if the value is a smi.
275 void RecordWrite( 276 void RecordWrite(
276 Register object, 277 Register object,
277 Register address, 278 Register address,
278 Register value, 279 Register value,
279 SaveFPRegsMode save_fp, 280 SaveFPRegsMode save_fp,
280 RememberedSetAction remembered_set_action = EMIT_REMEMBERED_SET, 281 RememberedSetAction remembered_set_action = EMIT_REMEMBERED_SET,
281 SmiCheck smi_check = INLINE_SMI_CHECK); 282 SmiCheck smi_check = INLINE_SMI_CHECK);
282 283
(...skipping 1136 matching lines...) Expand 10 before | Expand all | Expand 10 after
1419 masm->popfd(); \ 1420 masm->popfd(); \
1420 } \ 1421 } \
1421 masm-> 1422 masm->
1422 #else 1423 #else
1423 #define ACCESS_MASM(masm) masm-> 1424 #define ACCESS_MASM(masm) masm->
1424 #endif 1425 #endif
1425 1426
1426 } } // namespace v8::internal 1427 } } // namespace v8::internal
1427 1428
1428 #endif // V8_X64_MACRO_ASSEMBLER_X64_H_ 1429 #endif // V8_X64_MACRO_ASSEMBLER_X64_H_
OLDNEW
« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698