Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: src/arm/macro-assembler-arm.h

Issue 7977005: Put back the asserts in RememberedSetHelper, but correct this time. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 Register address); 174 Register address);
175 175
176 enum RememberedSetFinalAction { 176 enum RememberedSetFinalAction {
177 kReturnAtEnd, 177 kReturnAtEnd,
178 kFallThroughAtEnd 178 kFallThroughAtEnd
179 }; 179 };
180 180
181 // Record in the remembered set the fact that we have a pointer to new space 181 // Record in the remembered set the fact that we have a pointer to new space
182 // at the address pointed to by the addr register. Only works if addr is not 182 // at the address pointed to by the addr register. Only works if addr is not
183 // in new space. 183 // in new space.
184 void RememberedSetHelper(Register addr, 184 void RememberedSetHelper(Register object, // Used for debug code.
185 Register addr,
185 Register scratch, 186 Register scratch,
186 SaveFPRegsMode save_fp, 187 SaveFPRegsMode save_fp,
187 RememberedSetFinalAction and_then); 188 RememberedSetFinalAction and_then);
188 189
189 void CheckPageFlag(Register object, 190 void CheckPageFlag(Register object,
190 Register scratch, 191 Register scratch,
191 int mask, 192 int mask,
192 Condition cc, 193 Condition cc,
193 Label* condition_met); 194 Label* condition_met);
194 195
195 // Check if object is in new space. Jumps if the object is not in new space. 196 // Check if object is in new space. Jumps if the object is not in new space.
196 // The register scratch can be object itself, but it will be clobbered. 197 // The register scratch can be object itself, but scratch will be clobbered.
197 void JumpIfNotInNewSpace(Register object, 198 void JumpIfNotInNewSpace(Register object,
198 Register scratch, 199 Register scratch,
199 Label* branch) { 200 Label* branch) {
200 InNewSpace(object, scratch, ne, branch); 201 InNewSpace(object, scratch, ne, branch);
201 } 202 }
202 203
203 // Check if object is in new space. Jumps if the object is in new space. 204 // Check if object is in new space. Jumps if the object is in new space.
204 // The register scratch can be object itself, but it will be clobbered. 205 // The register scratch can be object itself, but it will be clobbered.
205 void JumpIfInNewSpace(Register object, 206 void JumpIfInNewSpace(Register object,
206 Register scratch, 207 Register scratch,
(...skipping 1046 matching lines...) Expand 10 before | Expand all | Expand 10 after
1253 #define __FILE_LINE__ __FILE__ ":" CODE_COVERAGE_TOSTRING(__LINE__) 1254 #define __FILE_LINE__ __FILE__ ":" CODE_COVERAGE_TOSTRING(__LINE__)
1254 #define ACCESS_MASM(masm) masm->stop(__FILE_LINE__); masm-> 1255 #define ACCESS_MASM(masm) masm->stop(__FILE_LINE__); masm->
1255 #else 1256 #else
1256 #define ACCESS_MASM(masm) masm-> 1257 #define ACCESS_MASM(masm) masm->
1257 #endif 1258 #endif
1258 1259
1259 1260
1260 } } // namespace v8::internal 1261 } } // namespace v8::internal
1261 1262
1262 #endif // V8_ARM_MACRO_ASSEMBLER_ARM_H_ 1263 #endif // V8_ARM_MACRO_ASSEMBLER_ARM_H_
OLDNEW
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698