src/arm/macro-assembler-arm.h - Issue 7977005: Put back the asserts in RememberedSetHelper, but correct this time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/macro-assembler-arm.h

Issue 7977005: Put back the asserts in RememberedSetHelper, but correct this time. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/macro-assembler-arm.h

===================================================================

--- src/arm/macro-assembler-arm.h (revision 9343)

+++ src/arm/macro-assembler-arm.h (working copy)

@@ -181,7 +181,8 @@

// Record in the remembered set the fact that we have a pointer to new space

// at the address pointed to by the addr register. Only works if addr is not

// in new space.

- void RememberedSetHelper(Register addr,

+ void RememberedSetHelper(Register object, // Used for debug code.

+ Register addr,

SaveFPRegsMode save_fp,

RememberedSetFinalAction and_then);

@@ -193,7 +194,7 @@

Label* condition_met);

// Check if object is in new space. Jumps if the object is not in new space.

- // The register scratch can be object itself, but it will be clobbered.

+ // The register scratch can be object itself, but scratch will be clobbered.

void JumpIfNotInNewSpace(Register object,

Label* branch) {

« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »