src/arm/full-codegen-arm.cc - Issue 7977005: Put back the asserts in RememberedSetHelper, but correct this time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/full-codegen-arm.cc

Issue 7977005: Put back the asserts in RememberedSetHelper, but correct this time. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/full-codegen-arm.cc

===================================================================

--- src/arm/full-codegen-arm.cc (revision 9343)

+++ src/arm/full-codegen-arm.cc (working copy)

@@ -3174,10 +3174,16 @@

// pauses in the middle of scanning a single object. Therefore the

// incremental marker is not disturbed, so we don't need to call the

// RecordWrite stub that notifies the incremental marker.

- __ RememberedSetHelper(

- index1, scratch2, kDontSaveFPRegs, MacroAssembler::kFallThroughAtEnd);

- __ RememberedSetHelper(

- index2, scratch2, kDontSaveFPRegs, MacroAssembler::kFallThroughAtEnd);

+ __ RememberedSetHelper(elements,

+ index1,

+ scratch2,

+ kDontSaveFPRegs,

+ MacroAssembler::kFallThroughAtEnd);

+ __ RememberedSetHelper(elements,

+ index2,

+ scratch2,

+ kDontSaveFPRegs,

+ MacroAssembler::kFallThroughAtEnd);

__ bind(&no_remembered_set);

// We are done. Drop elements from the stack, and return undefined.

« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/macro-assembler-arm.h » ('j') | no next file with comments »