Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 7977005: Put back the asserts in RememberedSetHelper, but correct this time. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/macro-assembler-arm.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3156 matching lines...) Expand 10 before | Expand all | Expand 10 after
3167 1 << MemoryChunk::SCAN_ON_SCAVENGE, 3167 1 << MemoryChunk::SCAN_ON_SCAVENGE,
3168 ne, 3168 ne,
3169 &no_remembered_set); 3169 &no_remembered_set);
3170 // Possible optimization: do a check that both values are Smis 3170 // Possible optimization: do a check that both values are Smis
3171 // (or them and test against Smi mask.) 3171 // (or them and test against Smi mask.)
3172 3172
3173 // We are swapping two objects in an array and the incremental marker never 3173 // We are swapping two objects in an array and the incremental marker never
3174 // pauses in the middle of scanning a single object. Therefore the 3174 // pauses in the middle of scanning a single object. Therefore the
3175 // incremental marker is not disturbed, so we don't need to call the 3175 // incremental marker is not disturbed, so we don't need to call the
3176 // RecordWrite stub that notifies the incremental marker. 3176 // RecordWrite stub that notifies the incremental marker.
3177 __ RememberedSetHelper( 3177 __ RememberedSetHelper(elements,
3178 index1, scratch2, kDontSaveFPRegs, MacroAssembler::kFallThroughAtEnd); 3178 index1,
3179 __ RememberedSetHelper( 3179 scratch2,
3180 index2, scratch2, kDontSaveFPRegs, MacroAssembler::kFallThroughAtEnd); 3180 kDontSaveFPRegs,
3181 MacroAssembler::kFallThroughAtEnd);
3182 __ RememberedSetHelper(elements,
3183 index2,
3184 scratch2,
3185 kDontSaveFPRegs,
3186 MacroAssembler::kFallThroughAtEnd);
3181 3187
3182 __ bind(&no_remembered_set); 3188 __ bind(&no_remembered_set);
3183 // We are done. Drop elements from the stack, and return undefined. 3189 // We are done. Drop elements from the stack, and return undefined.
3184 __ Drop(3); 3190 __ Drop(3);
3185 __ LoadRoot(r0, Heap::kUndefinedValueRootIndex); 3191 __ LoadRoot(r0, Heap::kUndefinedValueRootIndex);
3186 __ jmp(&done); 3192 __ jmp(&done);
3187 3193
3188 __ bind(&slow_case); 3194 __ bind(&slow_case);
3189 __ CallRuntime(Runtime::kSwapElements, 3); 3195 __ CallRuntime(Runtime::kSwapElements, 3);
3190 3196
(...skipping 1053 matching lines...) Expand 10 before | Expand all | Expand 10 after
4244 *context_length = 0; 4250 *context_length = 0;
4245 return previous_; 4251 return previous_;
4246 } 4252 }
4247 4253
4248 4254
4249 #undef __ 4255 #undef __
4250 4256
4251 } } // namespace v8::internal 4257 } } // namespace v8::internal
4252 4258
4253 #endif // V8_TARGET_ARCH_ARM 4259 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/macro-assembler-arm.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698