Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 7977005: Put back the asserts in RememberedSetHelper, but correct this time. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ia32/macro-assembler-ia32.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3150 matching lines...) Expand 10 before | Expand all | Expand 10 after
3161 not_zero, 3161 not_zero,
3162 &no_remembered_set, 3162 &no_remembered_set,
3163 Label::kNear); 3163 Label::kNear);
3164 // Possible optimization: do a check that both values are Smis 3164 // Possible optimization: do a check that both values are Smis
3165 // (or them and test against Smi mask.) 3165 // (or them and test against Smi mask.)
3166 3166
3167 // We are swapping two objects in an array and the incremental marker never 3167 // We are swapping two objects in an array and the incremental marker never
3168 // pauses in the middle of scanning a single object. Therefore the 3168 // pauses in the middle of scanning a single object. Therefore the
3169 // incremental marker is not disturbed, so we don't need to call the 3169 // incremental marker is not disturbed, so we don't need to call the
3170 // RecordWrite stub that notifies the incremental marker. 3170 // RecordWrite stub that notifies the incremental marker.
3171 __ RememberedSetHelper( 3171 __ RememberedSetHelper(elements,
3172 index_1, temp, kDontSaveFPRegs, MacroAssembler::kFallThroughAtEnd); 3172 index_1,
3173 __ RememberedSetHelper( 3173 temp,
3174 index_2, temp, kDontSaveFPRegs, MacroAssembler::kFallThroughAtEnd); 3174 kDontSaveFPRegs,
3175 MacroAssembler::kFallThroughAtEnd);
3176 __ RememberedSetHelper(elements,
3177 index_2,
3178 temp,
3179 kDontSaveFPRegs,
3180 MacroAssembler::kFallThroughAtEnd);
3175 3181
3176 __ bind(&no_remembered_set); 3182 __ bind(&no_remembered_set);
3177 3183
3178 // We are done. Drop elements from the stack, and return undefined. 3184 // We are done. Drop elements from the stack, and return undefined.
3179 __ add(Operand(esp), Immediate(3 * kPointerSize)); 3185 __ add(Operand(esp), Immediate(3 * kPointerSize));
3180 __ mov(eax, isolate()->factory()->undefined_value()); 3186 __ mov(eax, isolate()->factory()->undefined_value());
3181 __ jmp(&done); 3187 __ jmp(&done);
3182 3188
3183 __ bind(&slow_case); 3189 __ bind(&slow_case);
3184 __ CallRuntime(Runtime::kSwapElements, 3); 3190 __ CallRuntime(Runtime::kSwapElements, 3);
(...skipping 1112 matching lines...) Expand 10 before | Expand all | Expand 10 after
4297 *context_length = 0; 4303 *context_length = 0;
4298 return previous_; 4304 return previous_;
4299 } 4305 }
4300 4306
4301 4307
4302 #undef __ 4308 #undef __
4303 4309
4304 } } // namespace v8::internal 4310 } } // namespace v8::internal
4305 4311
4306 #endif // V8_TARGET_ARCH_IA32 4312 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ia32/macro-assembler-ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698