Issue 7633055: base: Fix the TODO in string_util.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7633055: base: Fix the TODO in string_util.h (Closed)

Created:
9 years, 4 months ago by tfarina

Modified:
9 years, 4 months ago

Reviewers:
brettw, Evan Martin

CC:
chromium-reviews, cbentzel+watch_chromium.org, erikwright (departed), rkn, Randy Smith (Not in Mondays), darin-cc_chromium.org, brettw-cc_chromium.org, estade+watch_chromium.org, jshin+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

base: Fix the TODO in string_util.h This removes the include of stringprintf.h from string_util.h and fix the clients. BUG=None TEST=None R=evan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97067

Patch Set 1 #

Patch Set 2 : fix chromeos #

Patch Set 3 : fix linux and linux_view #

Patch Set 4 : more chromeos fixes #

Patch Set 5 : fix network_stats.cc #

Patch Set 6 : more fixes #

Patch Set 7 : fix self_reg_work_item.cc #

Patch Set 8 : fix google_chrome_distribution.cc #

Patch Set 9 : fix gateway_data_provider_win.cc #

Patch Set 10 : more fixes #

Patch Set 11 : fix ie7_password.cc #

Patch Set 12 : fix chrome_mini_installer.cc #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+100 lines, -66 lines)			Patch
M	base/string_util.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/app/breakpad_win.cc	View	1 2 3 4 5 6 7 8 9	4 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/bug_report_util.cc	View	1 2 3 4 5 6 7 8 9	2 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_manager.cc	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/xkeyboard.cc	View	1	3 chunks	+11 lines, -8 lines	0 comments	Download
M	chrome/browser/chromeos/status/power_menu_button.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/system/syslogs_provider.cc	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/version_loader.cc	View	1	2 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/geolocation/wifi_data_provider_unittest_chromeos.cc	View	1 2 3	2 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/google/google_update.cc	View	1 2 3 4 5 6 7 8 9	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/net/network_stats.cc	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/password_manager/ie7_password.cc	View	1 2 3 4 5 6 7 8 9 10	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/password_manager/native_backend_gnome_x_unittest.cc	View	1 2	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/password_manager/native_backend_kwallet_x.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_x_unittest.cc	View	1 2	2 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/shell_integration_win.cc	View	1 2 3 4 5 6 7 8 9	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/bookmarks/bookmark_utils_gtk.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/flash_ui.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/favicon_webui_handler.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc	View	1	4 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/installer/util/google_chrome_distribution.cc	View	1 2 3 4 5 6 7	2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/installer/util/l10n_string_util.cc	View	1 2 3 4 5	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/installer/util/self_reg_work_item.cc	View	1 2 3 4 5 6	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/test/base/chrome_process_util_mac.cc	View	1 2 3 4 5	3 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/test/mini_installer_test/chrome_mini_installer.cc	View	1 2 3 4 5 6 7 8 9 10 11	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome_frame/ready_mode/internal/registry_ready_mode_state.cc	View	1 2 3 4 5 6 7 8	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/geolocation/gateway_data_provider_win.cc	View	1 2 3 4 5 6 7 8	2 chunks	+5 lines, -4 lines	0 comments	Download
M	content/browser/mach_broker_mac.cc	View	1 2 3 4 5	3 chunks	+3 lines, -2 lines	0 comments	Download
M	content/common/sandbox_mac.mm	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/base/cookie_monster.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	skia/ext/vector_canvas_unittest.cc	View	1 2 3 4 5 6 7 8 9	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM for net/base/cookie_monster.cc only.

Expand Messages | Collapse Messages