Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1234)

Unified Diff: chrome/browser/bug_report_util.cc

Issue 7633055: base: Fix the TODO in string_util.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix chrome_mini_installer.cc Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/breakpad_win.cc ('k') | chrome/browser/chromeos/input_method/input_method_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/bug_report_util.cc
diff --git a/chrome/browser/bug_report_util.cc b/chrome/browser/bug_report_util.cc
index 4560fbe9ab07f507c89d11561ac61af544f8d232..f00f85ea891137defa97ab427bde2db932a67356 100644
--- a/chrome/browser/bug_report_util.cc
+++ b/chrome/browser/bug_report_util.cc
@@ -12,6 +12,7 @@
#include "base/file_version_info.h"
#include "base/memory/singleton.h"
#include "base/string_util.h"
+#include "base/stringprintf.h"
#include "base/utf_string_conversions.h"
#include "base/win/windows_version.h"
#include "chrome/browser/browser_process_impl.h"
@@ -158,11 +159,13 @@ void BugReportUtil::SetOSVersion(std::string* os_version) {
#if defined(OS_WIN)
base::win::OSInfo* os_info = base::win::OSInfo::GetInstance();
base::win::OSInfo::VersionNumber version_number = os_info->version_number();
- *os_version = StringPrintf("%d.%d.%d", version_number.major,
- version_number.minor, version_number.build);
+ *os_version = base::StringPrintf("%d.%d.%d",
+ version_number.major,
+ version_number.minor,
+ version_number.build);
int service_pack = os_info->service_pack().major;
if (service_pack > 0)
- os_version->append(StringPrintf("Service Pack %d", service_pack));
+ os_version->append(base::StringPrintf("Service Pack %d", service_pack));
#elif defined(OS_MACOSX)
*os_version = base::SysInfo::OperatingSystemVersion();
#else
« no previous file with comments | « chrome/app/breakpad_win.cc ('k') | chrome/browser/chromeos/input_method/input_method_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698