Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2155)

Unified Diff: chrome/browser/password_manager/password_store_x_unittest.cc

Issue 7633055: base: Fix the TODO in string_util.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix chrome_mini_installer.cc Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_store_x_unittest.cc
diff --git a/chrome/browser/password_manager/password_store_x_unittest.cc b/chrome/browser/password_manager/password_store_x_unittest.cc
index 4ab880b2075983dae6a4af6d0493ae256693fc75..bb09d4ebef443be733ebac208dfc818b243b0b4b 100644
--- a/chrome/browser/password_manager/password_store_x_unittest.cc
+++ b/chrome/browser/password_manager/password_store_x_unittest.cc
@@ -8,6 +8,7 @@
#include "base/scoped_temp_dir.h"
#include "base/stl_util.h"
#include "base/string_util.h"
+#include "base/stringprintf.h"
#include "base/synchronization/waitable_event.h"
#include "base/time.h"
#include "base/utf_string_conversions.h"
@@ -245,9 +246,11 @@ class LoginDatabaseQueryTask : public Task {
void InitExpectedForms(bool autofillable, size_t count, VectorOfForms* forms) {
const char* domain = autofillable ? "example" : "blacklisted";
for (size_t i = 0; i < count; ++i) {
- std::string realm = StringPrintf("http://%zu.%s.com", i, domain);
- std::string origin = StringPrintf("http://%zu.%s.com/origin", i, domain);
- std::string action = StringPrintf("http://%zu.%s.com/action", i, domain);
+ std::string realm = base::StringPrintf("http://%zu.%s.com", i, domain);
+ std::string origin = base::StringPrintf("http://%zu.%s.com/origin",
+ i, domain);
+ std::string action = base::StringPrintf("http://%zu.%s.com/action",
+ i, domain);
PasswordFormData data = {
PasswordForm::SCHEME_HTML,
realm.c_str(),
« no previous file with comments | « chrome/browser/password_manager/native_backend_kwallet_x.cc ('k') | chrome/browser/shell_integration_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698