chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc - Issue 7633055: base: Fix the TODO in string_util.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc

Issue 7633055: base: Fix the TODO in string_util.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix chrome_mini_installer.cc Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc ('k') | chrome/installer/util/google_chrome_distribution.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc

diff --git a/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc b/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc

index de29ab150c8bc4f83cd5e932f3dc36d66dacbc5a..3a2fdb758a074e980908ba0a3dc917f42f225c6f 100644

--- a/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc

+++ b/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc

@@ -16,6 +16,7 @@

#include "base/i18n/time_formatting.h"

#include "base/string16.h"

#include "base/string_number_conversions.h"

+#include "base/stringprintf.h"

#include "base/time.h"

#include "base/utf_string_conversions.h"

#include "base/values.h"

@@ -820,7 +821,7 @@ void InternetOptionsHandler::PopulateCellularDetails(

dictionary->SetString("firmwareRevision", device->firmware_revision());

dictionary->SetString("hardwareRevision", device->hardware_revision());

dictionary->SetString("prlVersion",

- StringPrintf("%u", device->prl_version()));

+ base::StringPrintf("%u", device->prl_version()));

dictionary->SetString("meid", device->meid());

dictionary->SetString("imei", device->imei());

dictionary->SetString("mdn", device->mdn());