Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: chrome/app/breakpad_win.cc

Issue 7633055: base: Fix the TODO in string_util.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix chrome_mini_installer.cc Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/string_util.h ('k') | chrome/browser/bug_report_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/breakpad_win.cc
diff --git a/chrome/app/breakpad_win.cc b/chrome/app/breakpad_win.cc
index b85312507a11a980544a752387280d18d2cf9b5c..d24bcdaf6abbd93523dd05016a5cf84a81470d73 100644
--- a/chrome/app/breakpad_win.cc
+++ b/chrome/app/breakpad_win.cc
@@ -19,6 +19,7 @@
#include "base/memory/scoped_ptr.h"
#include "base/string_split.h"
#include "base/string_util.h"
+#include "base/stringprintf.h"
#include "base/utf_string_conversions.h"
#include "base/win/registry.h"
#include "base/win/win_util.h"
@@ -141,7 +142,7 @@ google_breakpad::CustomClientInfo* GetCustomInfo(const std::wstring& dll_path,
g_extension_ids_offset = g_custom_entries->size();
for (int i = 0; i < kMaxReportedActiveExtensions; ++i) {
g_custom_entries->push_back(google_breakpad::CustomInfoEntry(
- StringPrintf(L"extension-%i", i + 1).c_str(), L""));
+ base::StringPrintf(L"extension-%i", i + 1).c_str(), L""));
}
// Add empty values for the gpu_info. We'll put the actual values
@@ -177,7 +178,7 @@ google_breakpad::CustomClientInfo* GetCustomInfo(const std::wstring& dll_path,
g_url_chunks_offset = g_custom_entries->size();
for (int i = 0; i < kMaxUrlChunks; ++i) {
g_custom_entries->push_back(google_breakpad::CustomInfoEntry(
- StringPrintf(L"url-chunk-%i", i + 1).c_str(), L""));
+ base::StringPrintf(L"url-chunk-%i", i + 1).c_str(), L""));
}
} else {
g_custom_entries->push_back(
@@ -342,7 +343,7 @@ static void SetIntegerValue(size_t offset, int value) {
wcscpy_s((*g_custom_entries)[offset].value,
google_breakpad::CustomInfoEntry::kValueMaxLength,
- StringPrintf(L"%d", value).c_str());
+ base::StringPrintf(L"%d", value).c_str());
}
extern "C" void __declspec(dllexport) __cdecl SetNumberOfExtensions(
« no previous file with comments | « base/string_util.h ('k') | chrome/browser/bug_report_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698