chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc - Issue 7633055: base: Fix the TODO in string_util.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc

Issue 7633055: base: Fix the TODO in string_util.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix chrome_mini_installer.cc Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/ntp/favicon_webui_handler.cc ('k') | chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc

diff --git a/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc b/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc

index f0b3ae42da4fec33ff4f923b846fc10d0899fdf1..b6e028e54450c42bb2c9610961f50b14834ef104 100644

--- a/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc

+++ b/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc

@@ -8,6 +8,7 @@

#include <set>

#include <vector>

+#include "base/stringprintf.h"

#include "base/utf_string_conversions.h"

#include "base/values.h"

#include "chrome/app/chrome_command_ids.h"

@@ -198,7 +199,7 @@ void CrosLanguageOptionsHandler::RestartCallback(const ListValue* args) {

void CrosLanguageOptionsHandler::InputMethodDisableCallback(

const ListValue* args) {

const std::string input_method_id = UTF16ToASCII(ExtractStringValue(args));

- const std::string action = StringPrintf(

+ const std::string action = base::StringPrintf(

"LanguageOptions_DisableInputMethod_%s", input_method_id.c_str());

UserMetrics::RecordComputedAction(action);

}

@@ -206,7 +207,7 @@ void CrosLanguageOptionsHandler::InputMethodDisableCallback(

void CrosLanguageOptionsHandler::InputMethodEnableCallback(

const ListValue* args) {

const std::string input_method_id = UTF16ToASCII(ExtractStringValue(args));

- const std::string action = StringPrintf(

+ const std::string action = base::StringPrintf(

"LanguageOptions_EnableInputMethod_%s", input_method_id.c_str());

UserMetrics::RecordComputedAction(action);

}

@@ -214,7 +215,7 @@ void CrosLanguageOptionsHandler::InputMethodEnableCallback(

void CrosLanguageOptionsHandler::InputMethodOptionsOpenCallback(

const ListValue* args) {

const std::string input_method_id = UTF16ToASCII(ExtractStringValue(args));

- const std::string action = StringPrintf(

+ const std::string action = base::StringPrintf(

"InputMethodOptions_Open_%s", input_method_id.c_str());

UserMetrics::RecordComputedAction(action);

}