Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Side by Side Diff: content/browser/mach_broker_mac.cc

Issue 7633055: base: Fix the TODO in string_util.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix chrome_mini_installer.cc Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/browser/geolocation/gateway_data_provider_win.cc ('k') | content/common/sandbox_mac.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/mach_broker_mac.h" 5 #include "content/browser/mach_broker_mac.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/mac/foundation_util.h" 9 #include "base/mac/foundation_util.h"
10 #include "base/mach_ipc_mac.h" 10 #include "base/mach_ipc_mac.h"
11 #include "base/string_util.h" 11 #include "base/string_util.h"
12 #include "base/stringprintf.h"
12 #include "base/sys_string_conversions.h" 13 #include "base/sys_string_conversions.h"
13 #include "base/threading/platform_thread.h" 14 #include "base/threading/platform_thread.h"
14 #include "content/browser/browser_thread.h" 15 #include "content/browser/browser_thread.h"
15 #include "content/browser/renderer_host/render_process_host.h" 16 #include "content/browser/renderer_host/render_process_host.h"
16 #include "content/common/child_process_info.h" 17 #include "content/common/child_process_info.h"
17 #include "content/common/content_switches.h" 18 #include "content/common/content_switches.h"
18 #include "content/common/notification_service.h" 19 #include "content/common/notification_service.h"
19 20
20 namespace { 21 namespace {
21 // Prints a string representation of a Mach error code. 22 // Prints a string representation of a Mach error code.
22 std::string MachErrorCode(kern_return_t err) { 23 std::string MachErrorCode(kern_return_t err) {
23 return StringPrintf("0x%x %s", err, mach_error_string(err)); 24 return base::StringPrintf("0x%x %s", err, mach_error_string(err));
24 } 25 }
25 } // namespace 26 } // namespace
26 27
27 // Required because notifications happen on the UI thread. 28 // Required because notifications happen on the UI thread.
28 class RegisterNotificationTask : public Task { 29 class RegisterNotificationTask : public Task {
29 public: 30 public:
30 RegisterNotificationTask( 31 RegisterNotificationTask(
31 MachBroker* broker) 32 MachBroker* broker)
32 : broker_(broker) { } 33 : broker_(broker) { }
33 34
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
218 InvalidatePid(handle); 219 InvalidatePid(handle);
219 } 220 }
220 221
221 // static 222 // static
222 std::string MachBroker::GetMachPortName() { 223 std::string MachBroker::GetMachPortName() {
223 const CommandLine* command_line = CommandLine::ForCurrentProcess(); 224 const CommandLine* command_line = CommandLine::ForCurrentProcess();
224 const bool is_child = command_line->HasSwitch(switches::kProcessType); 225 const bool is_child = command_line->HasSwitch(switches::kProcessType);
225 226
226 // In non-browser (child) processes, use the parent's pid. 227 // In non-browser (child) processes, use the parent's pid.
227 const pid_t pid = is_child ? getppid() : getpid(); 228 const pid_t pid = is_child ? getppid() : getpid();
228 return StringPrintf("%s.rohitfork.%d", base::mac::BaseBundleID(), pid); 229 return base::StringPrintf("%s.rohitfork.%d", base::mac::BaseBundleID(), pid);
229 } 230 }
OLDNEW
« no previous file with comments | « content/browser/geolocation/gateway_data_provider_win.cc ('k') | content/common/sandbox_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698