Issue 6330007: Don't use GetAsTabContents. Send notifications from TabContentsView instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6330007: Don't use GetAsTabContents. Send notifications from TabContentsView instead. (Closed)

Created:
9 years, 11 months ago by jochen (gone - plz use gerrit)

Modified:
9 years, 7 months ago

Reviewers:
tburkard, jam, yzshen1, Matt Perry, brettw, Ben Goodger (Google)

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, brettw-cc_chromium.org, pam+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Don't use GetAsTabContents. Send notifications from TabContentsView instead. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72354

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -64 lines)			Patch
M	chrome/browser/extensions/extension_host.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_host.cc	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/notifications/balloon_host.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/notifications/balloon_host.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/prerender/prerender_contents.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/prerender/prerender_contents.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host_delegate.h	View	4 chunks	+12 lines, -11 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_helper.cc	View	2 chunks	+2 lines, -14 lines	0 comments	Download
M	chrome/browser/tab_contents/background_contents.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/background_contents.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/tab_contents/interstitial_page.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents_view.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents_view.cc	View	3 chunks	+14 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

please review (mainly brett, others fyi)

9 years, 11 months ago (2011-01-22 07:57:39 UTC) #1

Thanks! LGTM.

Expand Messages | Collapse Messages