chrome/browser/renderer_host/render_view_host.cc - Issue 6330007: Don't use GetAsTabContents. Send notifications from TabContentsView instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/render_view_host.cc

Issue 6330007: Don't use GetAsTabContents. Send notifications from TabContentsView instead. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/renderer_host/render_view_host.cc

diff --git a/chrome/browser/renderer_host/render_view_host.cc b/chrome/browser/renderer_host/render_view_host.cc

index 730042795be32b9f7356b00b0912f472ee287094..5f12b626ed66729ca15cc43ffeb3421c1426f9de 100644

--- a/chrome/browser/renderer_host/render_view_host.cc

+++ b/chrome/browser/renderer_host/render_view_host.cc

@@ -871,13 +871,12 @@ bool RenderViewHost::IsRenderView() const {

void RenderViewHost::CreateNewWindow(

int route_id,

- WindowContainerType window_container_type,

- const string16& frame_name) {

+ const ViewHostMsg_CreateWindow_Params& params) {

RenderViewHostDelegate::View* view = delegate_->GetViewDelegate();

if (!view)

return;

- view->CreateNewWindow(route_id, window_container_type, frame_name);

+ view->CreateNewWindow(route_id, params);

}

void RenderViewHost::CreateNewWidget(int route_id,

« no previous file with comments | « chrome/browser/renderer_host/render_view_host.h ('k') | chrome/browser/renderer_host/render_view_host_delegate.h » ('j') | no next file with comments »