Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: chrome/browser/tab_contents/interstitial_page.cc

Issue 6330007: Don't use GetAsTabContents. Send notifications from TabContentsView instead. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/tab_contents/background_contents.cc ('k') | chrome/browser/tab_contents/tab_contents_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/interstitial_page.cc
diff --git a/chrome/browser/tab_contents/interstitial_page.cc b/chrome/browser/tab_contents/interstitial_page.cc
index c41c51963ca3a8c597f8484901bf591a6ac01b94..36f900461d70dfda12bd4ba8e0d534f2e83a9937 100644
--- a/chrome/browser/tab_contents/interstitial_page.cc
+++ b/chrome/browser/tab_contents/interstitial_page.cc
@@ -92,8 +92,7 @@ class InterstitialPage::InterstitialPageRVHViewDelegate
// RenderViewHostDelegate::View implementation:
virtual void CreateNewWindow(
int route_id,
- WindowContainerType window_container_type,
- const string16& frame_name);
+ const ViewHostMsg_CreateWindow_Params& params);
virtual void CreateNewWidget(int route_id,
WebKit::WebPopupType popup_type);
virtual void CreateNewFullscreenWidget(int route_id,
@@ -594,8 +593,7 @@ InterstitialPage::InterstitialPageRVHViewDelegate::
void InterstitialPage::InterstitialPageRVHViewDelegate::CreateNewWindow(
int route_id,
- WindowContainerType window_container_type,
- const string16& frame_name) {
+ const ViewHostMsg_CreateWindow_Params& params) {
NOTREACHED() << "InterstitialPage does not support showing popups yet.";
}
« no previous file with comments | « chrome/browser/tab_contents/background_contents.cc ('k') | chrome/browser/tab_contents/tab_contents_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698