chrome/browser/extensions/extension_host.h - Issue 6330007: Don't use GetAsTabContents. Send notifications from TabContentsView instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_host.h

Issue 6330007: Don't use GetAsTabContents. Send notifications from TabContentsView instead. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_host.h

diff --git a/chrome/browser/extensions/extension_host.h b/chrome/browser/extensions/extension_host.h

index 234e40e36b7a5796a18d2d21fe6b2cfaa709bbb4..51db0002b57632ec99ebf0e0d1a73c56a7ff0a04 100644

--- a/chrome/browser/extensions/extension_host.h

+++ b/chrome/browser/extensions/extension_host.h

@@ -139,8 +139,7 @@ class ExtensionHost : public RenderViewHostDelegate,

// RenderViewHostDelegate::View

virtual void CreateNewWindow(

int route_id,

- WindowContainerType window_container_type,

- const string16& frame_name);

+ const ViewHostMsg_CreateWindow_Params& params);

virtual void CreateNewWidget(int route_id, WebKit::WebPopupType popup_type);

virtual void CreateNewFullscreenWidget(int route_id,

WebKit::WebPopupType popup_type);

« no previous file with comments | « no previous file | chrome/browser/extensions/extension_host.cc » ('j') | no next file with comments »