Don't use GetAsTabContents. Send notifications from TabContentsView instead.

chrome/browser/tab_contents/tab_contents_view.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/tab_contents/tab_contents_view.h"
 
 #include "chrome/browser/renderer_host/render_process_host.h"
 #include "chrome/browser/renderer_host/render_view_host.h"
 #include "chrome/browser/renderer_host/render_widget_host.h"
 #include "chrome/browser/renderer_host/render_view_host_delegate.h"
 #include "chrome/browser/renderer_host/render_widget_host_view.h"
 #include "chrome/browser/tab_contents/tab_contents.h"
 #include "chrome/browser/tab_contents/tab_contents_delegate.h"
+#include "chrome/common/notification_service.h"
+#include "chrome/common/render_messages_params.h"
 
 TabContentsView::TabContentsView(TabContents* tab_contents)
     : tab_contents_(tab_contents) {
 }
 
 TabContentsView::~TabContentsView() {}
 
 void TabContentsView::RenderWidgetHostDestroyed(RenderWidgetHost* host) {
   if (host->view())
     host->view()->WillDestroyRenderWidget(host);
   delegate_view_helper_.RenderWidgetHostDestroyed(host);
 }
 
 void TabContentsView::RenderViewCreated(RenderViewHost* host) {
   // Default implementation does nothing. Platforms may override.
 }
 
 void TabContentsView::CreateNewWindow(
     int route_id,
-    WindowContainerType window_container_type,
-    const string16& frame_name) {
+    const ViewHostMsg_CreateWindow_Params& params) {
   TabContents* new_contents = delegate_view_helper_.CreateNewWindow(
       route_id,
       tab_contents_->profile(),
       tab_contents_->GetSiteInstance(),
       DOMUIFactory::GetDOMUIType(tab_contents_->profile(),
           tab_contents_->GetURL()),
       tab_contents_,
-      window_container_type,
-      frame_name);
+      params.window_container_type,
+      params.frame_name);
 
-  if (new_contents && tab_contents_->delegate())
-    tab_contents_->delegate()->TabContentsCreated(new_contents);
+  if (new_contents) {
+    NotificationService::current()->Notify(
+        NotificationType::CREATING_NEW_WINDOW,
+        Source<TabContents>(tab_contents_),
+        Details<const ViewHostMsg_CreateWindow_Params>(&params));
+
+    if (tab_contents_->delegate())
+      tab_contents_->delegate()->TabContentsCreated(new_contents);
+  }
 }
 
 void TabContentsView::CreateNewWidget(int route_id,
                                       WebKit::WebPopupType popup_type) {
   CreateNewWidgetInternal(route_id, popup_type);
 }
 
 void TabContentsView::CreateNewFullscreenWidget(
     int route_id, WebKit::WebPopupType popup_type) {
   CreateNewFullscreenWidgetInternal(route_id, popup_type);
@@ skipping 96 matching lines @@
 }
 
 void TabContentsView::ShowCreatedFullscreenWidgetInternal(
     RenderWidgetHostView* widget_host_view) {
   if (tab_contents_->delegate())
     tab_contents_->delegate()->RenderWidgetShowing();
 
   widget_host_view->InitAsFullscreen(tab_contents_->GetRenderWidgetHostView());
   widget_host_view->GetRenderWidgetHost()->Init();
 }