Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Side by Side Diff: chrome/browser/tab_contents/tab_contents_view.h

Issue 6330007: Don't use GetAsTabContents. Send notifications from TabContentsView instead. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_TAB_CONTENTS_TAB_CONTENTS_VIEW_H_ 5 #ifndef CHROME_BROWSER_TAB_CONTENTS_TAB_CONTENTS_VIEW_H_
6 #define CHROME_BROWSER_TAB_CONTENTS_TAB_CONTENTS_VIEW_H_ 6 #define CHROME_BROWSER_TAB_CONTENTS_TAB_CONTENTS_VIEW_H_
7 #pragma once 7 #pragma once
8 8
9 #include <map> 9 #include <map>
10 #include <string> 10 #include <string>
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 182
183 // Common implementations of some RenderViewHostDelegate::View methods. 183 // Common implementations of some RenderViewHostDelegate::View methods.
184 RenderViewHostDelegateViewHelper delegate_view_helper_; 184 RenderViewHostDelegateViewHelper delegate_view_helper_;
185 185
186 private: 186 private:
187 // We implement these functions on RenderViewHostDelegate::View directly and 187 // We implement these functions on RenderViewHostDelegate::View directly and
188 // do some book-keeping associated with the request. The request is then 188 // do some book-keeping associated with the request. The request is then
189 // forwarded to *Internal which does platform-specific work. 189 // forwarded to *Internal which does platform-specific work.
190 virtual void CreateNewWindow( 190 virtual void CreateNewWindow(
191 int route_id, 191 int route_id,
192 WindowContainerType window_container_type, 192 const ViewHostMsg_CreateWindow_Params& params);
193 const string16& frame_name);
194 virtual void CreateNewWidget(int route_id, WebKit::WebPopupType popup_type); 193 virtual void CreateNewWidget(int route_id, WebKit::WebPopupType popup_type);
195 virtual void CreateNewFullscreenWidget( 194 virtual void CreateNewFullscreenWidget(
196 int route_id, WebKit::WebPopupType popup_type); 195 int route_id, WebKit::WebPopupType popup_type);
197 virtual void ShowCreatedWindow(int route_id, 196 virtual void ShowCreatedWindow(int route_id,
198 WindowOpenDisposition disposition, 197 WindowOpenDisposition disposition,
199 const gfx::Rect& initial_pos, 198 const gfx::Rect& initial_pos,
200 bool user_gesture); 199 bool user_gesture);
201 virtual void ShowCreatedWidget(int route_id, const gfx::Rect& initial_pos); 200 virtual void ShowCreatedWidget(int route_id, const gfx::Rect& initial_pos);
202 virtual void Activate(); 201 virtual void Activate();
203 virtual void Deactivate(); 202 virtual void Deactivate();
204 virtual void ShowCreatedFullscreenWidget(int route_id); 203 virtual void ShowCreatedFullscreenWidget(int route_id);
205 204
206 // The TabContents whose contents we display. 205 // The TabContents whose contents we display.
207 TabContents* tab_contents_; 206 TabContents* tab_contents_;
208 207
209 // Tracks created TabContents objects that have not been shown yet. They are 208 // Tracks created TabContents objects that have not been shown yet. They are
210 // identified by the route ID passed to CreateNewWindow. 209 // identified by the route ID passed to CreateNewWindow.
211 typedef std::map<int, TabContents*> PendingContents; 210 typedef std::map<int, TabContents*> PendingContents;
212 PendingContents pending_contents_; 211 PendingContents pending_contents_;
213 212
214 // These maps hold on to the widgets that we created on behalf of the 213 // These maps hold on to the widgets that we created on behalf of the
215 // renderer that haven't shown yet. 214 // renderer that haven't shown yet.
216 typedef std::map<int, RenderWidgetHostView*> PendingWidgetViews; 215 typedef std::map<int, RenderWidgetHostView*> PendingWidgetViews;
217 PendingWidgetViews pending_widget_views_; 216 PendingWidgetViews pending_widget_views_;
218 217
219 DISALLOW_COPY_AND_ASSIGN(TabContentsView); 218 DISALLOW_COPY_AND_ASSIGN(TabContentsView);
220 }; 219 };
221 220
222 #endif // CHROME_BROWSER_TAB_CONTENTS_TAB_CONTENTS_VIEW_H_ 221 #endif // CHROME_BROWSER_TAB_CONTENTS_TAB_CONTENTS_VIEW_H_
OLDNEW
« no previous file with comments | « chrome/browser/tab_contents/interstitial_page.cc ('k') | chrome/browser/tab_contents/tab_contents_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698