Don't use GetAsTabContents. Send notifications from TabContentsView instead.

chrome/browser/renderer_host/render_view_host_delegate.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_
 #define CHROME_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 28 matching lines @@
 struct RendererPreferences;
 class RenderProcessHost;
 class RenderViewHost;
 class ResourceRedirectDetails;
 class ResourceRequestDetails;
 class SkBitmap;
 class SSLClientAuthHandler;
 class SSLAddCertHandler;
 class TabContents;
 struct ThumbnailScore;
+struct ViewHostMsg_CreateWindow_Params;
 struct ViewHostMsg_DidPrintPage_Params;
 struct ViewHostMsg_DomMessage_Params;
 struct ViewHostMsg_FrameNavigate_Params;
 struct ViewHostMsg_PageHasOSDD_Type;
 struct ViewHostMsg_RunFileChooser_Params;
 struct WebApplicationInfo;
 struct WebDropData;
 struct WebMenuItem;
 class WebKeyboardEvent;
 struct WebPreferences;
@@ skipping 35 matching lines @@
 //  exposing a more generic Send function on RenderViewHost and a response
 //  listener here to serve that need.
 //
 class RenderViewHostDelegate : public IPC::Channel::Listener {
  public:
   // View ----------------------------------------------------------------------
   // Functions that can be routed directly to a view-specific class.
 
   class View {
    public:
-    // The page is trying to open a new page (e.g. a popup window). The
-    // window should be created associated with the given route, but it should
-    // not be shown yet. That should happen in response to ShowCreatedWindow.
-    // |window_container_type| describes the type of RenderViewHost container
-    // that is requested -- in particular, the window.open call may have
-    // specified 'background' and 'persistent' in the feature string.
+    // The page is trying to open a new page (e.g. a popup window). The window
+    // should be created associated with the given route, but it should not be
+    // shown yet. That should happen in response to ShowCreatedWindow.
+    // |params.window_container_type| describes the type of RenderViewHost
+    // container that is requested -- in particular, the window.open call may
+    // have specified 'background' and 'persistent' in the feature string.
     //
-    // The passed |frame_name| parameter is the name parameter that was passed
-    // to window.open(), and will be empty if none was passed.
+    // The passed |params.frame_name| parameter is the name parameter that was
+    // passed to window.open(), and will be empty if none was passed.
     //
     // Note: this is not called "CreateWindow" because that will clash with
     // the Windows function which is actually a #define.
     //
     // NOTE: this takes ownership of @modal_dialog_event
     virtual void CreateNewWindow(
         int route_id,
-        WindowContainerType window_container_type,
-        const string16& frame_name) = 0;
+        const ViewHostMsg_CreateWindow_Params& params) = 0;
 
     // The page is trying to open a new widget (e.g. a select popup). The
     // widget should be created associated with the given route, but it should
     // not be shown yet. That should happen in response to ShowCreatedWidget.
     // |popup_type| indicates if the widget is a popup and what kind of popup it
     // is (select, autofill...).
     virtual void CreateNewWidget(int route_id,
                                  WebKit::WebPopupType popup_type) = 0;
 
     // Creates a full screen RenderWidget. Similar to above.
@@ skipping 348 matching lines @@
       GetAutomationResourceRoutingDelegate();
 
   // IPC::Channel::Listener implementation.
   // This is used to give the delegate a chance to filter IPC messages.
   virtual bool OnMessageReceived(const IPC::Message& message);
 
   // Gets the URL that is currently being displayed, if there is one.
   virtual const GURL& GetURL() const;
 
   // Return this object cast to a TabContents, if it is one. If the object is
-  // not a TabContents, returns NULL.
+  // not a TabContents, returns NULL. DEPRECATED: Be sure to include brettw and
+  // jam as reviewers before you use this method.
   virtual TabContents* GetAsTabContents();
 
   // Return this object cast to a BackgroundContents, if it is one. If the
   // object is not a BackgroundContents, returns NULL.
   virtual BackgroundContents* GetAsBackgroundContents();
 
   // Return id number of browser window which this object is attached to. If no
   // browser window is attached to, just return -1.
   virtual int GetBrowserWindowID() const = 0;
 
@@ skipping 175 matching lines @@
                                 bool remember) {}
 
   // Notification that a worker process has crashed.
   void WorkerCrashed() {}
 
  protected:
   virtual ~RenderViewHostDelegate() {}
 };
 
 #endif  // CHROME_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_