Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 5841002: Finish deinlining virtual methods. (Closed)

Created:
10 years ago by Elliot Glaysher
Modified:
9 years, 7 months ago
CC:
chromium-reviews, vrk (LEFT CHROMIUM), annacc, stuartmorgan+watch_chromium.org, ncarter (slow), fbarchard, Alpha Left Google, Erik does not do reviews, jam, darin-cc_chromium.org, brettw-cc_chromium.org, tim (not reviewing), ddorwin+watch_chromium.org, Raghu Simha, cbentzel+watch_chromium.org, pam+watch_chromium.org, awong, scherkus (not reviewing), sjl, idana, Aaron Boodman, acolwell GONE FROM CHROMIUM, Paweł Hajdan Jr., hans
Visibility:
Public.

Description

Almost done deinlining virtual methods. BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69470

Patch Set 1 #

Patch Set 2 : Windows fixes #

Patch Set 3 : revert parts of the balloon modifications #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+553 lines, -203 lines) Patch
M chrome/browser/automation/ui_controls_internal.h View 1 chunk +3 lines, -12 lines 0 comments Download
A chrome/browser/automation/ui_controls_internal.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/browser/device_orientation/data_fetcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/device_orientation/provider_impl.cc View 1 chunk +4 lines, -6 lines 1 comment Download
M chrome/browser/dom_ui/bug_report_ui.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_tts_api.h View 2 chunks +5 lines, -10 lines 0 comments Download
M chrome/browser/extensions/extension_tts_api.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/browser/gpu_blacklist.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/gpu_blacklist.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/gtk/first_run_bubble.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/first_run_bubble.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/gtk/notifications/balloon_view_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/notifications/balloon_view_gtk.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/modal_html_dialog_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/modal_html_dialog_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/policy/dummy_configuration_policy_provider.h View 1 chunk +6 lines, -9 lines 0 comments Download
A chrome/browser/policy/dummy_configuration_policy_provider.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/browser/ppapi_plugin_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ppapi_plugin_process_host.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service.h View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_data_type_controller.h View 1 chunk +9 lines, -20 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_data_type_controller.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/data_type_manager_impl.h View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/data_type_manager_impl.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/database_model_worker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/database_model_worker.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/extension_data_type_controller.h View 1 chunk +9 lines, -20 lines 0 comments Download
M chrome/browser/sync/glue/extension_data_type_controller.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/history_model_worker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/history_model_worker.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/password_model_worker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/password_model_worker.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/preference_data_type_controller.h View 1 chunk +9 lines, -20 lines 0 comments Download
M chrome/browser/sync/glue/preference_data_type_controller.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/preference_model_associator.h View 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/sync/glue/preference_model_associator.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/session_data_type_controller.h View 1 chunk +6 lines, -17 lines 0 comments Download
M chrome/browser/sync/glue/session_data_type_controller.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/interstitial_page.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_gtk.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_gtk.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.h View 4 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.cc View 5 chunks +57 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/notifications/balloon_view.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/notifications/balloon_view.cc View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/notifications/balloon_view_host.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/views/notifications/balloon_view_host.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/devtools_agent_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/devtools_agent_filter.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/renderer/media/ipc_video_decoder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/media/ipc_video_decoder.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/renderer/safe_browsing/feature_extractor_clock.h View 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/renderer/safe_browsing/feature_extractor_clock.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/service/cloud_print/printer_job_handler.h View 1 chunk +4 lines, -8 lines 0 comments Download
M chrome/service/cloud_print/printer_job_handler.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/net.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M net/proxy/init_proxy_resolver_unittest.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M net/proxy/multi_threaded_proxy_resolver_unittest.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M net/proxy/proxy_config_service_fixed.h View 1 chunk +3 lines, -5 lines 0 comments Download
A net/proxy/proxy_config_service_fixed.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M net/proxy/proxy_resolver.h View 1 chunk +1 line, -4 lines 0 comments Download
M net/proxy/proxy_resolver_mac.h View 1 2 2 chunks +6 lines, -8 lines 0 comments Download
M net/proxy/proxy_resolver_mac.cc View 1 2 2 chunks +21 lines, -0 lines 0 comments Download
M net/proxy/proxy_resolver_v8.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/proxy/proxy_resolver_v8.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/proxy/proxy_resolver_winhttp.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M net/proxy/proxy_resolver_winhttp.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M net/proxy/proxy_script_fetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_service.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M net/proxy/proxy_service_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/proxy/sync_host_resolver_bridge_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/plugins/webplugin_file_delegate.h View 1 chunk +1 line, -3 lines 0 comments Download
A webkit/glue/plugins/webplugin_file_delegate.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M webkit/glue/plugins/webview_plugin.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/glue/plugins/webview_plugin.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Elliot Glaysher
Only BalloonCollection remains, but is non-trivial enough to require some care.
10 years ago (2010-12-16 18:17:11 UTC) #1
James Hawkins
LGTM
10 years ago (2010-12-16 21:22:42 UTC) #2
Lei Zhang
10 years ago (2010-12-16 21:31:51 UTC) #3 
LGTM

http://codereview.chromium.org/5841002/diff/5001/chrome/browser/device_orient...
File chrome/browser/device_orientation/provider_impl.cc (right):

http://codereview.chromium.org/5841002/diff/5001/chrome/browser/device_orient...
chrome/browser/device_orientation/provider_impl.cc:195: return
kDesiredSamplingIntervalMs;
+hans, fyi

Powered by Google App Engine
This is Rietveld 408576698