Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: net/proxy/proxy_resolver_mac.h

Issue 5841002: Finish deinlining virtual methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: revert parts of the balloon modifications Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/proxy/proxy_resolver_mac.h
diff --git a/net/proxy/proxy_resolver_mac.h b/net/proxy/proxy_resolver_mac.h
index 950b11f79962090a20b17ad29f95b4fdf02917fc..fe6e791505201f82f7d97b5afcdc8386d8ddc5b9 100644
--- a/net/proxy/proxy_resolver_mac.h
+++ b/net/proxy/proxy_resolver_mac.h
@@ -16,7 +16,8 @@ namespace net {
// proxies.
class ProxyResolverMac : public ProxyResolver {
public:
- ProxyResolverMac() : ProxyResolver(false /*expects_pac_bytes*/) {}
+ ProxyResolverMac();
+ virtual ~ProxyResolverMac();
// ProxyResolver methods:
virtual int GetProxyForURL(const GURL& url,
@@ -25,16 +26,13 @@ class ProxyResolverMac : public ProxyResolver {
RequestHandle* request,
const BoundNetLog& net_log);
- virtual void CancelRequest(RequestHandle request) {
- NOTREACHED();
- }
+ virtual void CancelRequest(RequestHandle request);
+
+ virtual void CancelSetPacScript();
virtual int SetPacScript(
const scoped_refptr<ProxyResolverScriptData>& script_data,
- CompletionCallback* /*callback*/) {
- script_data_ = script_data;
- return OK;
- }
+ CompletionCallback* /*callback*/);
private:
scoped_refptr<ProxyResolverScriptData> script_data_;

Powered by Google App Engine
This is Rietveld 408576698