Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: chrome/browser/extensions/extension_tts_api.h

Issue 5841002: Finish deinlining virtual methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: revert parts of the balloon modifications Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_tts_api.h
diff --git a/chrome/browser/extensions/extension_tts_api.h b/chrome/browser/extensions/extension_tts_api.h
index 2f99f20b7b214cb4fd24bf29cf66760d62fd0c88..2e4e9bba712a72b06a4d134b6f0e69ce4178e945 100644
--- a/chrome/browser/extensions/extension_tts_api.h
+++ b/chrome/browser/extensions/extension_tts_api.h
@@ -40,9 +40,9 @@ class ExtensionTtsPlatformImpl {
// Return true if the synthesis engine is currently speaking.
virtual bool IsSpeaking() = 0;
- virtual std::string error() { return error_; }
- virtual void clear_error() { error_ = std::string(); }
- virtual void set_error(const std::string& error) { error_ = error; }
+ virtual std::string error();
+ virtual void clear_error();
+ virtual void set_error(const std::string& error);
protected:
ExtensionTtsPlatformImpl() {}
@@ -60,13 +60,8 @@ class ExtensionTtsController {
static ExtensionTtsController* GetInstance();
struct Utterance {
- Utterance()
- : rate(-1.0),
- pitch(-1.0),
- volume(-1.0),
- success_task(NULL),
- failure_task(NULL) {
- }
+ Utterance();
+ ~Utterance();
std::string text;
std::string language;

Powered by Google App Engine
This is Rietveld 408576698