Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/proxy/proxy_resolver.h

Issue 5841002: Finish deinlining virtual methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: revert parts of the balloon modifications Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/device_orientation/provider_impl.cc ('K') | « net/proxy/proxy_config_service_fixed.cc ('k') | net/proxy/proxy_resolver_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_resolver.h
diff --git a/net/proxy/proxy_resolver.h b/net/proxy/proxy_resolver.h
index 9220f5ea33ebf34149f60a682d4f8a648509c7ff..fcc2395f5129d2444f9a1dcd0916a30ce6133254 100644
--- a/net/proxy/proxy_resolver.h
+++ b/net/proxy/proxy_resolver.h
@@ -54,10 +54,7 @@ class ProxyResolver {
// contain the actual script bytes rather than just the URL.
bool expects_pac_bytes() const { return expects_pac_bytes_; }
- // TODO(eroman): Make this =0.
- virtual void CancelSetPacScript() {
- NOTREACHED();
- }
+ virtual void CancelSetPacScript() = 0;
// Frees any unneeded memory held by the resolver, e.g. garbage in the JS
// engine. Most subclasses don't need to do anything, so we provide a default
« chrome/browser/device_orientation/provider_impl.cc ('K') | « net/proxy/proxy_config_service_fixed.cc ('k') | net/proxy/proxy_resolver_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698