Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5409)

Unified Diff: chrome/browser/task_manager/task_manager_resource_providers.cc

Issue 5841002: Finish deinlining virtual methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: revert parts of the balloon modifications Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_manager/task_manager_resource_providers.cc
diff --git a/chrome/browser/task_manager/task_manager_resource_providers.cc b/chrome/browser/task_manager/task_manager_resource_providers.cc
index 47819e3a717767916d229df6d44f98035e90a18c..40a23b22d56a4431dd8d3b6a500af1edc098c321 100644
--- a/chrome/browser/task_manager/task_manager_resource_providers.cc
+++ b/chrome/browser/task_manager/task_manager_resource_providers.cc
@@ -134,6 +134,22 @@ base::ProcessHandle TaskManagerRendererResource::GetProcess() const {
return process_;
}
+TaskManager::Resource::Type TaskManagerRendererResource::GetType() const {
+ return RENDERER;
+}
+
+bool TaskManagerRendererResource::ReportsCacheStats() const {
+ return true;
+}
+
+bool TaskManagerRendererResource::ReportsV8MemoryStats() const {
+ return true;
+}
+
+bool TaskManagerRendererResource::SupportNetworkUsage() const {
+ return true;
+}
+
////////////////////////////////////////////////////////////////////////////////
// TaskManagerTabContentsResource class
////////////////////////////////////////////////////////////////////////////////
@@ -888,6 +904,19 @@ base::ProcessHandle TaskManagerExtensionProcessResource::GetProcess() const {
return process_handle_;
}
+TaskManager::Resource::Type
+TaskManagerExtensionProcessResource::GetType() const {
+ return EXTENSION;
+}
+
+bool TaskManagerExtensionProcessResource::SupportNetworkUsage() const {
+ return true;
+}
+
+void TaskManagerExtensionProcessResource::SetSupportNetworkUsage() {
+ NOTREACHED();
+}
+
const Extension* TaskManagerExtensionProcessResource::GetExtension() const {
return extension_host_->extension();
}
@@ -1062,6 +1091,10 @@ TaskManagerNotificationResource::TaskManagerNotificationResource(
TaskManagerNotificationResource::~TaskManagerNotificationResource() {
}
+std::wstring TaskManagerNotificationResource::GetTitle() const {
+ return title_;
+}
+
SkBitmap TaskManagerNotificationResource::GetIcon() const {
return *default_icon_;
}
@@ -1070,6 +1103,14 @@ base::ProcessHandle TaskManagerNotificationResource::GetProcess() const {
return process_handle_;
}
+TaskManager::Resource::Type TaskManagerNotificationResource::GetType() const {
+ return NOTIFICATION;
+}
+
+bool TaskManagerNotificationResource::SupportNetworkUsage() const {
+ return false;
+}
+
////////////////////////////////////////////////////////////////////////////////
// TaskManagerNotificationResourceProvider class
////////////////////////////////////////////////////////////////////////////////
@@ -1239,6 +1280,22 @@ base::ProcessHandle TaskManagerBrowserProcessResource::GetProcess() const {
return base::GetCurrentProcessHandle(); // process_;
}
+TaskManager::Resource::Type TaskManagerBrowserProcessResource::GetType() const {
+ return BROWSER;
+}
+
+bool TaskManagerBrowserProcessResource::SupportNetworkUsage() const {
+ return true;
+}
+
+void TaskManagerBrowserProcessResource::SetSupportNetworkUsage() {
+ NOTREACHED();
+}
+
+bool TaskManagerBrowserProcessResource::ReportsSqliteMemoryUsed() const {
+ return true;
+}
+
////////////////////////////////////////////////////////////////////////////////
// TaskManagerBrowserProcessResourceProvider class
////////////////////////////////////////////////////////////////////////////////

Powered by Google App Engine
This is Rietveld 408576698