Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: chrome/browser/task_manager/task_manager_resource_providers.h

Issue 5841002: Finish deinlining virtual methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: revert parts of the balloon modifications Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_manager/task_manager_resource_providers.h
diff --git a/chrome/browser/task_manager/task_manager_resource_providers.h b/chrome/browser/task_manager/task_manager_resource_providers.h
index cf29bc25596107f95ff65e697817200162118bc9..b43a2d35a8139bd9905995c621b7bf023e0978f0 100644
--- a/chrome/browser/task_manager/task_manager_resource_providers.h
+++ b/chrome/browser/task_manager/task_manager_resource_providers.h
@@ -36,15 +36,15 @@ class TaskManagerRendererResource : public TaskManager::Resource {
// TaskManager::Resource methods:
virtual base::ProcessHandle GetProcess() const;
- virtual Type GetType() const { return RENDERER; }
- virtual bool ReportsCacheStats() const { return true; }
+ virtual Type GetType() const;
+ virtual bool ReportsCacheStats() const;
virtual WebKit::WebCache::ResourceTypeStats GetWebCoreCacheStats() const;
- virtual bool ReportsV8MemoryStats() const { return true; }
+ virtual bool ReportsV8MemoryStats() const;
virtual size_t GetV8MemoryAllocated() const;
virtual size_t GetV8MemoryUsed() const;
// RenderResources always provide the network usage.
- virtual bool SupportNetworkUsage() const { return true; }
+ virtual bool SupportNetworkUsage() const;
virtual void SetSupportNetworkUsage() { }
virtual void Refresh();
@@ -298,9 +298,9 @@ class TaskManagerExtensionProcessResource : public TaskManager::Resource {
virtual std::wstring GetTitle() const;
virtual SkBitmap GetIcon() const;
virtual base::ProcessHandle GetProcess() const;
- virtual Type GetType() const { return EXTENSION; }
- virtual bool SupportNetworkUsage() const { return true; }
- virtual void SetSupportNetworkUsage() { NOTREACHED(); }
+ virtual Type GetType() const;
+ virtual bool SupportNetworkUsage() const;
+ virtual void SetSupportNetworkUsage();
virtual const Extension* GetExtension() const;
// Returns the pid of the extension process.
@@ -370,11 +370,11 @@ class TaskManagerNotificationResource : public TaskManager::Resource {
virtual ~TaskManagerNotificationResource();
// TaskManager::Resource interface
- virtual std::wstring GetTitle() const { return title_; }
+ virtual std::wstring GetTitle() const;
virtual SkBitmap GetIcon() const;
virtual base::ProcessHandle GetProcess() const;
- virtual Type GetType() const { return NOTIFICATION; }
- virtual bool SupportNetworkUsage() const { return false; }
+ virtual Type GetType() const;
+ virtual bool SupportNetworkUsage() const;
virtual void SetSupportNetworkUsage() { }
private:
@@ -438,12 +438,12 @@ class TaskManagerBrowserProcessResource : public TaskManager::Resource {
virtual std::wstring GetTitle() const;
virtual SkBitmap GetIcon() const;
virtual base::ProcessHandle GetProcess() const;
- virtual Type GetType() const { return BROWSER; }
+ virtual Type GetType() const;
- virtual bool SupportNetworkUsage() const { return true; }
- virtual void SetSupportNetworkUsage() { NOTREACHED(); }
+ virtual bool SupportNetworkUsage() const;
+ virtual void SetSupportNetworkUsage();
- virtual bool ReportsSqliteMemoryUsed() const { return true; }
+ virtual bool ReportsSqliteMemoryUsed() const;
virtual size_t SqliteMemoryUsedBytes() const;
// Returns the pid of the browser process.

Powered by Google App Engine
This is Rietveld 408576698