chrome/browser/modal_html_dialog_delegate.h - Issue 5841002: Finish deinlining virtual methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/modal_html_dialog_delegate.h

Issue 5841002: Finish deinlining virtual methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert parts of the balloon modifications Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/modal_html_dialog_delegate.h

diff --git a/chrome/browser/modal_html_dialog_delegate.h b/chrome/browser/modal_html_dialog_delegate.h

index 9336b3bc8d290ffd4007306b7bebf264034ce962..dbdd8122f04bf2d9e4bd0d70c5123782a36c1db6 100644

--- a/chrome/browser/modal_html_dialog_delegate.h

+++ b/chrome/browser/modal_html_dialog_delegate.h

@@ -47,7 +47,7 @@ class ModalHtmlDialogDelegate

virtual std::string GetDialogArgs() const;

virtual void OnDialogClosed(const std::string& json_retval);

virtual void OnCloseContents(TabContents* source, bool* out_close_dialog) { }

- virtual bool ShouldShowDialogTitle() const { return true; }

+ virtual bool ShouldShowDialogTitle() const;

private:

NotificationRegistrar registrar_;