Largely reduce the number of pylint warnings and fix one typo.

Largely reduce the number of pylint warnings and fix one typo.

Most of them are style issues or variable aliasing.

TEST=Can almost enable pylint warnings
BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64908

[jochen (gone - plz use gerrit), 2010-11-03 13:39:04]

lgtm

http://codereview.chromium.org/4360002/diff/1/2
File breakpad.py (right):

http://codereview.chromium.org/4360002/diff/1/2#newcode49
breakpad.py:49: print '\n'.join('  %s: %s' % (k, v[0:50]) for k, v in
params.iteritems())
what's the rule for using print (...) vs print ...?

http://codereview.chromium.org/4360002/diff/1/12
File presubmit_support.py (right):

http://codereview.chromium.org/4360002/diff/1/12#newcode2
presubmit_support.py:2: # Copyright (c) 2006-2009 The Chromium Authors. All
rights reserved.
nit. non-std license header

http://codereview.chromium.org/4360002/diff/1/17
File trychange.py (right):

http://codereview.chromium.org/4360002/diff/1/17#newcode4
trychange.py:4: # found in the LICENSE file.
nit. add empty line below

[M-A Ruel, 2010-11-03 14:07:33]

http://codereview.chromium.org/4360002/diff/1/2
File breakpad.py (right):

http://codereview.chromium.org/4360002/diff/1/2#newcode49
breakpad.py:49: print '\n'.join('  %s: %s' % (k, v[0:50]) for k, v in
params.iteritems())
On 2010/11/03 13:39:04, jochen wrote:
> what's the rule for using print (...) vs print ...?

print() is python3 compatible so occasionally I fix those when I think about it.
In a year or so I'll probably start making it more compliant.