Largely reduce the number of pylint warnings and fix one typo.

presubmit_canned_checks.py

 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic presubmit checks that can be reused by other presubmit checks."""
 
 ### Description checks
 
 def CheckChangeHasTestField(input_api, output_api):
   """Requires that the changelist have a TEST= field."""
@@ skipping 257 matching lines @@
       if len(bad) == 5:  # Just show the first 5 errors.
         break
 
   if bad:
     msg = 'Found lines longer than %s characters (first 5 shown).' % maxlen
     return [output_api.PresubmitPromptWarning(msg, items=bad)]
   else:
     return []
 
 
-def CheckLicense(input_api, output_api, license, source_file_filter=None,
+def CheckLicense(input_api, output_api, license_re, source_file_filter=None,
     accept_empty_files=True):
   """Verifies the license header.
   """
-  license_re = input_api.re.compile(license, input_api.re.MULTILINE)
+  license_re = input_api.re.compile(license_re, input_api.re.MULTILINE)
   bad_files = []
   for f in input_api.AffectedSourceFiles(source_file_filter):
     contents = input_api.ReadFile(f, 'rb')
     if accept_empty_files and not contents:
       continue
     if not license_re.search(contents):
       bad_files.append(f.LocalPath())
   if bad_files:
     if input_api.is_committing:
       res_type = output_api.PresubmitPromptWarning
@@ skipping 183 matching lines @@
     return []
   # Reformat as an dict of platform: [status, url]
   values = dict([[v[0], [v[1], v[2]]] for v in values if len(v) == 3])
   if not values:
     # It returned useless data.
     return [output_api.PresubmitNotifyResult('Failed to parse try job results')]
 
   for platform in platforms:
     values.setdefault(platform, ['not started', ''])
   message = None
-  non_success = [k.upper() for k,v in values.iteritems() if v[0] != 'success']
+  non_success = [k.upper() for k, v in values.iteritems() if v[0] != 'success']
   if 'failure' in [v[0] for v in values.itervalues()]:
     message = 'Try job failures on %s!\n' % ', '.join(non_success)
   elif non_success:
     message = ('Unfinished (or not even started) try jobs on '
                 '%s.\n') % ', '.join(non_success)
   if message:
     message += (
         'Is try server wrong or broken? Please notify %s. '
         'Thanks.\n' % owner)
     return [output_api.PresubmitPromptWarning(message=message)]
@@ skipping 27 matching lines @@
     pending_builds_len = len(builder.get('pending_builds', []))
     if pending_builds_len > max_pendings:
       out.append('%s has %d build(s) pending' %
                   (builder_name, pending_builds_len))
   if out:
     return [output_api.PresubmitPromptWarning(
         'Build(s) pending. It is suggested to wait that no more than %d '
             'builds are pending.' % max_pendings,
         long_text='\n'.join(out))]
   return []