Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Unified Diff: chrome-update.py

Issue 4360002: Largely reduce the number of pylint warnings and fix one typo. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: address comments Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « breakpad.py ('k') | drover.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome-update.py
diff --git a/chrome-update.py b/chrome-update.py
index d1eb1768fd4edd63d28933d3228d75d14f74a3aa..38893617838e059ad8427534c61a7e8c516a9c3d 100755
--- a/chrome-update.py
+++ b/chrome-update.py
@@ -15,9 +15,9 @@ COMPILE_URL = BASE_URL + 'slave/compile.py'
UTILS_URL = BASE_URL + 'common/chromium_utils.py'
-def Fetch(url, file):
- if not os.path.exists(file):
- urllib.urlretrieve(url, file)
+def Fetch(url, filename):
+ if not os.path.exists(filename):
+ urllib.urlretrieve(url, filename)
def GetLastestRevision():
@@ -53,10 +53,10 @@ def DoUpdate(chrome_root):
def DoBuild(chrome_root, args):
"""Download compile.py and run it."""
- compile = os.path.join(chrome_root, 'compile.py')
- Fetch(COMPILE_URL, compile)
+ compile_path = os.path.join(chrome_root, 'compile.py')
+ Fetch(COMPILE_URL, compile_path)
Fetch(UTILS_URL, os.path.join(chrome_root, 'chromium_utils.py'))
- cmd = ['python', compile] + args
+ cmd = ['python', compile_path] + args
return subprocess.call(cmd, cwd=chrome_root, shell=IS_WIN)
« no previous file with comments | « breakpad.py ('k') | drover.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698