Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: gclient_utils.py

Issue 4360002: Largely reduce the number of pylint warnings and fix one typo. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: address comments Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gclient_scm.py ('k') | git-try » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient_utils.py
diff --git a/gclient_utils.py b/gclient_utils.py
index 4c74c5c5e41e4a787b1d87810412918197206a80..ecc59cc7f6555bd5a6ca8b0d1bfd61518bf5c4a3 100644
--- a/gclient_utils.py
+++ b/gclient_utils.py
@@ -14,7 +14,6 @@
"""Generic utils."""
-import copy
import errno
import logging
import os
@@ -300,7 +299,8 @@ def SoftClone(obj):
"""Clones an object. copy.copy() doesn't work on 'file' objects."""
if obj.__class__.__name__ == 'SoftCloned':
return obj
- class SoftCloned(object): pass
+ class SoftCloned(object):
+ pass
new_obj = SoftCloned()
for member in dir(obj):
if member.startswith('_'):
@@ -389,7 +389,7 @@ def MakeFileAnnotated(fileobj):
try:
# Detect threads no longer existing.
indexes = (getattr(t, 'index', None) for t in threading.enumerate())
- indexed = filter(None, indexes)
+ indexes = filter(None, indexes)
for index in new_fileobj.output_buffers:
if not index in indexes:
orphans.append((index, new_fileobj.output_buffers[index][0]))
@@ -480,7 +480,7 @@ def FindGclientRoot(from_dir, filename='.gclient'):
# might have failed. In that case, we cannot verify that the .gclient
# is the one we want to use. In order to not to cause too much trouble,
# just issue a warning and return the path anyway.
- print >>sys.stderr, ("%s file in parent directory %s might not be the "
+ print >> sys.stderr, ("%s file in parent directory %s might not be the "
"file you want to use" % (filename, path))
return path
scope = {}
« no previous file with comments | « gclient_scm.py ('k') | git-try » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698