Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: gclient.py

Issue 4360002: Largely reduce the number of pylint warnings and fix one typo. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: address comments Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gcl.py ('k') | gclient_scm.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient.py
diff --git a/gclient.py b/gclient.py
index 0d1e2f93f2f950066e8969fc208cba195a067b1a..054f52d93bbd76040372adb835333f6140666ddf 100644
--- a/gclient.py
+++ b/gclient.py
@@ -58,22 +58,21 @@ import os
import posixpath
import pprint
import re
-import subprocess
import sys
import urlparse
import urllib
-import breakpad
+import breakpad # pylint: disable=W0611
import gclient_scm
import gclient_utils
from third_party.repo.progress import Progress
-def attr(attr, data):
+def attr(attribute, data):
"""Sets an attribute on a function."""
def hook(fn):
- setattr(fn, attr, data)
+ setattr(fn, attribute, data)
return fn
return hook
« no previous file with comments | « gcl.py ('k') | gclient_scm.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698