Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Unified Diff: git_cl_hooks.py

Issue 4360002: Largely reduce the number of pylint warnings and fix one typo. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: address comments Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « git-try ('k') | presubmit_canned_checks.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl_hooks.py
diff --git a/git_cl_hooks.py b/git_cl_hooks.py
index 4519e422e37393751267b7b2b7d9ef830b505280..1ba66087ba2c4a547d87aa77d2837f1d635c284a 100644
--- a/git_cl_hooks.py
+++ b/git_cl_hooks.py
@@ -3,11 +3,10 @@
# found in the LICENSE file.
import os
-import re
import subprocess
import sys
-import breakpad
+import breakpad # pylint: disable=W0611
from git_cl_repo import git_cl
from git_cl_repo import upload
@@ -25,11 +24,11 @@ def Backquote(cmd, cwd=None):
cwd=cwd,
stdout=subprocess.PIPE).communicate()[0].strip()
-def ConvertToInteger(input):
+def ConvertToInteger(inputval):
"""Convert a string to integer, but returns either an int or None."""
try:
- return int(input)
- except TypeError, ValueError:
+ return int(inputval)
+ except (TypeError, ValueError):
return None
« no previous file with comments | « git-try ('k') | presubmit_canned_checks.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698