Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: tests/gclient_scm_test.py

Issue 4360002: Largely reduce the number of pylint warnings and fix one typo. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: address comments Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pylintrc ('k') | tests/gclient_utils_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/gclient_scm_test.py
diff --git a/tests/gclient_scm_test.py b/tests/gclient_scm_test.py
index a075d86c750f5eb49d69eda3fe00a98980665346..f49b2d82b2e9a561dd5285f261d2434620f700e5 100755
--- a/tests/gclient_scm_test.py
+++ b/tests/gclient_scm_test.py
@@ -17,6 +17,7 @@ import __builtin__
# Fixes include path.
from super_mox import mox, StdoutCheck, TestCaseUtils, SuperMoxTestBase
+import sys
import gclient_scm
# Shortcut since this function is used often
@@ -789,11 +790,11 @@ from :3
end = ('] test\n 1 files changed, 1 insertions(+), '
'1 deletions(-)\n\n_____ . at refs/heads/master\n'
'Attempting rebase onto refs/remotes/origin/master...\n')
- self.assertTrue(gclient_scm.sys.stdout.getvalue().startswith(start))
- self.assertTrue(gclient_scm.sys.stdout.getvalue().endswith(end))
- self.assertEquals(len(gclient_scm.sys.stdout.getvalue()),
+ self.assertTrue(sys.stdout.getvalue().startswith(start))
+ self.assertTrue(sys.stdout.getvalue().endswith(end))
+ self.assertEquals(len(sys.stdout.getvalue()),
len(start) + len(end) + 7)
- gclient_scm.sys.stdout.close()
+ sys.stdout.close()
def testUpdateNotGit(self):
if not self.enabled:
« no previous file with comments | « pylintrc ('k') | tests/gclient_utils_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698