Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3069014: Convert a bunch of easy AppendSwitchWithValue to *ASCII. (Closed)

Created:
10 years, 4 months ago by Evan Martin
Modified:
10 years, 4 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, Raghu Simha, cbentzel+watch_chromium.org, nkostylev+cc_chromium.org, idana, ben+cc_chromium.org, John Grabowski, Erik does not do reviews, Paweł Hajdan Jr., jam, ncarter (slow), Aaron Boodman, pam+watch_chromium.org, tim (not reviewing), brettw-cc_chromium.org, kuchhal, darin-cc_chromium.org, native-client-reviews_googlegroups.com, amit, davemoore+watch_chromium.org
Visibility:
Public.

Description

Convert a bunch of easy AppendSwitchWithValue to *ASCII. For this patch, I skipped over any instance where it wasn't a nearly trivial change. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54285

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -153 lines) Patch
M base/command_line_unittest.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/browser_child_process_host.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_shutdown.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_browsertest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/screen_locker_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/command_line_pref_store_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/configuration_policy_pref_store_unittest.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/first_run/first_run_gtk.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/first_run/first_run_win.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/gpu_process_host.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/importer/firefox_importer_unittest_utils_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/locale_tests_uitest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/nacl_host/nacl_broker_host_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context_unittest.cc View 1 chunk +10 lines, -11 lines 0 comments Download
M chrome/browser/plugin_process_host.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/profile_import_process_host.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/profile_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sanity_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/utility_process_host.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/worker_host/worker_process_host.cc View 2 chunks +5 lines, -6 lines 1 comment Download
M chrome/browser/zygote_host_linux.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/debug_flags.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/common/sandbox_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/nacl/broker_thread.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/renderer/external_extension_uitest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/renderer/renderer_main_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/service/service_utility_process_host.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/test/automation/automation_proxy_uitest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/in_process_browser_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/live_sync/live_sync_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/nacl/nacl_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/page_cycler/page_cycler_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/plugin/plugin_test.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/tab_switching/tab_switching_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/test_launcher/out_of_proc_test_runner.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/ui/pepper_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ui/sandbox_uitests.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/ui_test_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/chrome_frame_automation.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/chrome_launcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/chrome_tab.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/test/perf/chrome_frame_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
viettrungluu
10 years, 4 months ago (2010-07-30 02:33:16 UTC) #1 
LGTM. I failed, however, to find where you fixed a bug. :(

http://codereview.chromium.org/3069014/diff/2001/3024
File chrome/browser/worker_host/worker_process_host.cc (left):

http://codereview.chromium.org/3069014/diff/2001/3024#oldcode114
chrome/browser/worker_host/worker_process_host.cc:114:
switches::kEnableNativeWebWorkers)) {
Couldn't you convert most of these to CopyWhateverItWas()?

Powered by Google App Engine
This is Rietveld 408576698