Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3935)

Unified Diff: base/command_line_unittest.cc

Issue 3069014: Convert a bunch of easy AppendSwitchWithValue to *ASCII. (Closed)
Patch Set: fix Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/command_line_unittest.cc
diff --git a/base/command_line_unittest.cc b/base/command_line_unittest.cc
index c3fb04c0358a10f01e76e18435e87e4cb9661950..86b2117d050bf9981db660cdae970020fea669ef 100644
--- a/base/command_line_unittest.cc
+++ b/base/command_line_unittest.cc
@@ -101,18 +101,18 @@ TEST(CommandLineTest, EmptyString) {
TEST(CommandLineTest, AppendSwitches) {
std::string switch1 = "switch1";
std::string switch2 = "switch2";
- std::wstring value = L"value";
+ std::string value = "value";
std::string switch3 = "switch3";
- std::wstring value3 = L"a value with spaces";
+ std::string value3 = "a value with spaces";
std::string switch4 = "switch4";
- std::wstring value4 = L"\"a value with quotes\"";
+ std::string value4 = "\"a value with quotes\"";
CommandLine cl(FilePath(FILE_PATH_LITERAL("Program")));
cl.AppendSwitch(switch1);
- cl.AppendSwitchWithValue(switch2, value);
- cl.AppendSwitchWithValue(switch3, value3);
- cl.AppendSwitchWithValue(switch4, value4);
+ cl.AppendSwitchASCII(switch2, value);
+ cl.AppendSwitchASCII(switch3, value3);
+ cl.AppendSwitchASCII(switch4, value4);
EXPECT_TRUE(cl.HasSwitch(switch1));
EXPECT_TRUE(cl.HasSwitch(switch2));
« no previous file with comments | « no previous file | chrome/browser/browser_child_process_host.cc » ('j') | chrome/browser/worker_host/worker_process_host.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698