Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4228)

Unified Diff: chrome/browser/configuration_policy_pref_store_unittest.cc

Issue 3069014: Convert a bunch of easy AppendSwitchWithValue to *ASCII. (Closed)
Patch Set: fix Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/configuration_policy_pref_store_unittest.cc
diff --git a/chrome/browser/configuration_policy_pref_store_unittest.cc b/chrome/browser/configuration_policy_pref_store_unittest.cc
index 0cac13ff4fb0bf989bd7d43bb3367eb8767622e6..44eb7829834839abe0f78dd05865e3240308ba74 100644
--- a/chrome/browser/configuration_policy_pref_store_unittest.cc
+++ b/chrome/browser/configuration_policy_pref_store_unittest.cc
@@ -197,12 +197,12 @@ TEST_F(ConfigurationPolicyPrefStoreTest, TestSettingsProxyConfig) {
CommandLine command_line(unused_path);
command_line.AppendSwitch(switches::kNoProxyServer);
command_line.AppendSwitch(switches::kProxyAutoDetect);
- command_line.AppendSwitchWithValue(switches::kProxyPacUrl,
- "http://chromium.org/test.pac");
- command_line.AppendSwitchWithValue(switches::kProxyServer,
- "http://chromium2.org");
- command_line.AppendSwitchWithValue(switches::kProxyBypassList,
- "http://chromium3.org");
+ command_line.AppendSwitchASCII(switches::kProxyPacUrl,
+ "http://chromium.org/test.pac");
+ command_line.AppendSwitchASCII(switches::kProxyServer,
+ "http://chromium2.org");
+ command_line.AppendSwitchASCII(switches::kProxyBypassList,
+ "http://chromium3.org");
ConfigurationPolicyPrefStore store(&command_line, NULL);
EXPECT_EQ(store.ReadPrefs(), PrefStore::PREF_READ_ERROR_NONE);
@@ -231,12 +231,12 @@ TEST_F(ConfigurationPolicyPrefStoreTest, TestPolicyProxyConfigManualOverride) {
CommandLine command_line(unused_path);
command_line.AppendSwitch(switches::kNoProxyServer);
command_line.AppendSwitch(switches::kProxyAutoDetect);
- command_line.AppendSwitchWithValue(switches::kProxyPacUrl,
- "http://chromium.org/test.pac");
- command_line.AppendSwitchWithValue(switches::kProxyServer,
- "http://chromium.org");
- command_line.AppendSwitchWithValue(switches::kProxyBypassList,
- "http://chromium.org");
+ command_line.AppendSwitchASCII(switches::kProxyPacUrl,
+ "http://chromium.org/test.pac");
+ command_line.AppendSwitchASCII(switches::kProxyServer,
+ "http://chromium.org");
+ command_line.AppendSwitchASCII(switches::kProxyBypassList,
+ "http://chromium.org");
scoped_ptr<MockConfigurationPolicyProvider> provider(
new MockConfigurationPolicyProvider());

Powered by Google App Engine
This is Rietveld 408576698