Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: chrome/test/ui/ui_test.cc

Issue 3069014: Convert a bunch of easy AppendSwitchWithValue to *ASCII. (Closed)
Patch Set: fix Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/ui/ui_test.cc
diff --git a/chrome/test/ui/ui_test.cc b/chrome/test/ui/ui_test.cc
index f3eff50ad0e36ae7cf86b532923daa0b16107a08..d088661f0dec091373cd384ec1d8c413ded5e591 100644
--- a/chrome/test/ui/ui_test.cc
+++ b/chrome/test/ui/ui_test.cc
@@ -334,7 +334,7 @@ void UITestBase::StartHttpServerWithPort(const FilePath& root_directory,
const std::wstring& port) {
scoped_ptr<CommandLine> cmd_line(CreateHttpServerCommandLine());
ASSERT_TRUE(cmd_line.get());
- cmd_line->AppendSwitchWithValue("server", "start");
+ cmd_line->AppendSwitchASCII("server", "start");
cmd_line->AppendSwitch("register_cygwin");
cmd_line->AppendSwitchPath("root", root_directory);
@@ -355,7 +355,7 @@ void UITestBase::StartHttpServerWithPort(const FilePath& root_directory,
void UITestBase::StopHttpServer() {
scoped_ptr<CommandLine> cmd_line(CreateHttpServerCommandLine());
ASSERT_TRUE(cmd_line.get());
- cmd_line->AppendSwitchWithValue("server", "stop");
+ cmd_line->AppendSwitchASCII("server", "stop");
RunCommand(*cmd_line.get());
}
@@ -1118,7 +1118,7 @@ bool UITestBase::LaunchBrowserHelper(const CommandLine& arguments,
command_line.AppendSwitch(switches::kNoDefaultBrowserCheck);
// This is a UI test.
- command_line.AppendSwitchWithValue(switches::kTestType, kUITestType);
+ command_line.AppendSwitchASCII(switches::kTestType, kUITestType);
// Tell the browser to use a temporary directory just for this test.
command_line.AppendSwitchPath(switches::kUserDataDir, user_data_dir());
@@ -1131,8 +1131,8 @@ bool UITestBase::LaunchBrowserHelper(const CommandLine& arguments,
command_line.AppendSwitch(switches::kDomAutomationController);
if (include_testing_id_) {
- command_line.AppendSwitchWithValue(switches::kTestingChannelID,
- server_->channel_id());
+ command_line.AppendSwitchASCII(switches::kTestingChannelID,
+ server_->channel_id());
}
if (!show_error_dialogs_ &&

Powered by Google App Engine
This is Rietveld 408576698