chrome_frame/chrome_launcher_unittest.cc - Issue 3069014: Convert a bunch of easy AppendSwitchWithValue to *ASCII.

Side by Side Diff: chrome_frame/chrome_launcher_unittest.cc

Issue 3069014: Convert a bunch of easy AppendSwitchWithValue to *ASCII. (Closed)

Patch Set: fix Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« chrome/browser/worker_host/worker_process_host.cc ('K') | « chrome_frame/chrome_frame_automation.cc ('k') | chrome_frame/chrome_tab.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/command_line.h"	5 #include "base/command_line.h"

6 #include "base/file_path.h"	6 #include "base/file_path.h"

7 #include "base/logging.h"	7 #include "base/logging.h"

8 #include "chrome/common/chrome_switches.h"	8 #include "chrome/common/chrome_switches.h"

9 #include "chrome_frame/chrome_launcher.h"	9 #include "chrome_frame/chrome_launcher.h"

10 #include "testing/gtest/include/gtest/gtest.h"	10 #include "testing/gtest/include/gtest/gtest.h"

11	11

12 TEST(ChromeLauncher, IsValidCommandLine) {	12 TEST(ChromeLauncher, IsValidCommandLine) {

13 CommandLine bad(FilePath(L"dummy.exe"));	13 CommandLine bad(FilePath(L"dummy.exe"));

14 bad.AppendSwitch(switches::kNoFirstRun); // in whitelist	14 bad.AppendSwitch(switches::kNoFirstRun); // in whitelist

15 bad.AppendSwitch("no-such-switch"); // does not exist	15 bad.AppendSwitch("no-such-switch"); // does not exist

16 bad.AppendSwitch(switches::kHomePage); // exists but not in whitelist	16 bad.AppendSwitch(switches::kHomePage); // exists but not in whitelist

17	17

18 EXPECT_FALSE(chrome_launcher::IsValidCommandLine(	18 EXPECT_FALSE(chrome_launcher::IsValidCommandLine(

19 bad.command_line_string().c_str()));	19 bad.command_line_string().c_str()));

20	20

21 CommandLine good(FilePath(L"dummy.exe"));	21 CommandLine good(FilePath(L"dummy.exe"));

22 good.AppendSwitch(switches::kNoFirstRun); // in whitelist	22 good.AppendSwitch(switches::kNoFirstRun); // in whitelist

23 good.AppendSwitchWithValue(switches::kUserDataDir, "foo"); // in whitelist	23 good.AppendSwitchASCII(switches::kUserDataDir, "foo"); // in whitelist

24	24

25 EXPECT_TRUE(chrome_launcher::IsValidCommandLine(	25 EXPECT_TRUE(chrome_launcher::IsValidCommandLine(

26 good.command_line_string().c_str()));	26 good.command_line_string().c_str()));

27	27

28 CommandLine no_params(FilePath(L"dummy.exe"));	28 CommandLine no_params(FilePath(L"dummy.exe"));

29 EXPECT_TRUE(chrome_launcher::IsValidCommandLine(	29 EXPECT_TRUE(chrome_launcher::IsValidCommandLine(

30 no_params.command_line_string().c_str()));	30 no_params.command_line_string().c_str()));

31	31

32 CommandLine empty(FilePath(L""));	32 CommandLine empty(FilePath(L""));

33 EXPECT_TRUE(chrome_launcher::IsValidCommandLine(	33 EXPECT_TRUE(chrome_launcher::IsValidCommandLine(

(...skipping 31 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
65 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"chrome-frame"));	65 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"chrome-frame"));

66 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"-chrome-frame"));	66 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"-chrome-frame"));

67 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"---chrome-frame"));	67 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"---chrome-frame"));

68 EXPECT_FALSE(chrome_launcher::IsValidArgument(L" --chrome-frame"));	68 EXPECT_FALSE(chrome_launcher::IsValidArgument(L" --chrome-frame"));

69 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"--chrome-framefoobar"));	69 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"--chrome-framefoobar"));

70 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"foobar--chrome-frame"));	70 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"foobar--chrome-frame"));

71 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"--chrome-frames"));	71 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"--chrome-frames"));

72 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"--Chrome-frame"));	72 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"--Chrome-frame"));

73 EXPECT_FALSE(chrome_launcher::IsValidArgument(L""));	73 EXPECT_FALSE(chrome_launcher::IsValidArgument(L""));

74 }	74 }

OLD	NEW