Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: chrome/browser/sanity_uitest.cc

Issue 3069014: Convert a bunch of easy AppendSwitchWithValue to *ASCII. (Closed)
Patch Set: fix Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This is a file for random testcases that we run into that at one point or 5 // This is a file for random testcases that we run into that at one point or
6 // another have crashed the program. 6 // another have crashed the program.
7 7
8 #include "chrome/test/ui/ui_test.h" 8 #include "chrome/test/ui/ui_test.h"
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 // to exit fairly early. This was the cause of crashes. See bug 34799. 53 // to exit fairly early. This was the cause of crashes. See bug 34799.
54 class EarlyReturnTest : public UITest { 54 class EarlyReturnTest : public UITest {
55 public: 55 public:
56 EarlyReturnTest() { 56 EarlyReturnTest() {
57 wait_for_initial_loads_ = false; 57 wait_for_initial_loads_ = false;
58 // We don't depend on these timeouts, they are set to the minimum so 58 // We don't depend on these timeouts, they are set to the minimum so
59 // the automation server waits the minimun amount possible for the 59 // the automation server waits the minimun amount possible for the
60 // handshake that will never come. 60 // handshake that will never come.
61 set_command_execution_timeout_ms(1); 61 set_command_execution_timeout_ms(1);
62 set_action_timeout_ms(1); 62 set_action_timeout_ms(1);
63 launch_arguments_.AppendSwitchWithValue(switches::kTryChromeAgain, "10001"); 63 launch_arguments_.AppendSwitchASCII(switches::kTryChromeAgain, "10001");
64 } 64 }
65 }; 65 };
66 66
67 // Flaky: http://crbug.com/45115 67 // Flaky: http://crbug.com/45115
68 TEST_F(EarlyReturnTest, FLAKY_ToastCrasher) { 68 TEST_F(EarlyReturnTest, FLAKY_ToastCrasher) {
69 // UITest will check if this crashed. 69 // UITest will check if this crashed.
70 } 70 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698